Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(0.37.0): merge to develop #1387

Merged
merged 1 commit into from
Aug 3, 2023
Merged

release(0.37.0): merge to develop #1387

merged 1 commit into from
Aug 3, 2023

Conversation

seaerchin
Copy link
Contributor

What's Changed

Full Changelog: v0.36.0...v0.37.0

@seaerchin seaerchin requested a review from a team August 3, 2023 06:51
@seaerchin
Copy link
Contributor Author

seaerchin commented Aug 3, 2023

Tests @seaerchin

https://github.com/isomerpages/isomercms-frontend/assets/42832651/5a973b89-473f-4757-83eb-ebf2e5b9fdfa
Should be similar to what is shown in the video above.

  • open up settings page
  • change anything in the site desc and click save
  • wait for modal to pop out and close
  • change anything in the text field
  • assert that modal does not pop out again

@seaerchin
Copy link
Contributor Author

seaerchin commented Aug 3, 2023

Tests @seaerchin

Tests

  • go to a markdown page
  • click on back button
  • modal should show up
  • type in some feedback + rating
  • click done
  • modal should close
  • toast should show up

@seaerchin
Copy link
Contributor Author

seaerchin commented Aug 3, 2023

Tests @seaerchin

  • go to /sites
  • check if sites have a preview image (got network call but the impl reutrns empty array for admins)

@mergify
Copy link

mergify bot commented Aug 3, 2023

⚠️ The sha of the head commit of this PR conflicts with #1388. Mergify cannot evaluate rules on this PR. ⚠️

@seaerchin seaerchin temporarily deployed to staging August 3, 2023 07:19 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging August 3, 2023 07:20 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging August 3, 2023 07:20 — with GitHub Actions Inactive
@seaerchin seaerchin merged commit 2f1c2de into develop Aug 3, 2023
@seaerchin seaerchin deleted the release/0.37.0 branch August 3, 2023 11:52
@alexanderleegs alexanderleegs mentioned this pull request Aug 8, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants