Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preview): added preview images #1360

Merged
merged 3 commits into from
Jul 27, 2023
Merged

feat(preview): added preview images #1360

merged 3 commits into from
Jul 27, 2023

Conversation

caando
Copy link
Contributor

@caando caando commented Jul 20, 2023 •
edited
Loading

Problem

CMS dashboard page displays Isomer logo for all sites

Closes IS-266

Solution

This PR queries a new backend endpoint with a list of site names to get url of preview images. It tries to get the favicon from production site as preview image. If it is unsuccessful, Isomer logo will still be displayed.

Breaking Changes

Features:

  • Going to the site dashboard now displays the favicon of production site as preview image.

Before & After Screenshots

BEFORE:

image

AFTER:

image

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

@caando caando temporarily deployed to staging July 20, 2023 20:17 — with GitHub Actions Inactive
@caando caando mentioned this pull request Jul 20, 2023
Merged
2 tasks
@caando caando temporarily deployed to staging July 20, 2023 20:23 — with GitHub Actions Inactive
@caando caando requested a review from a team July 20, 2023 20:25
QiluXie
QiluXie reviewed Jul 24, 2023
View reviewed changes
src/hooks/allSitesHooks/useSitePreview.ts Outdated Show resolved Hide resolved
src/hooks/allSitesHooks/useSitePreview.ts Outdated Show resolved Hide resolved
src/layouts/Sites.tsx Outdated Show resolved Hide resolved
kishore03109
kishore03109 reviewed Jul 25, 2023
View reviewed changes
src/hooks/allSitesHooks/useSitePreview.ts Outdated Show resolved Hide resolved
src/types/sites.ts Outdated Show resolved Hide resolved
src/services/AllSitesService.ts Show resolved Hide resolved
src/layouts/Sites.tsx Show resolved Hide resolved
@caando caando requested review from QiluXie, kishore03109 and a team July 26, 2023 03:08
@caando caando temporarily deployed to staging July 26, 2023 03:27 — with GitHub Actions Inactive
@caando caando temporarily deployed to staging July 27, 2023 07:10 — with GitHub Actions Inactive
@caando caando merged commit 33fcbd3 into develop Jul 27, 2023
@mergify mergify bot deleted the feat/preview-images branch July 27, 2023 15:40
@seaerchin seaerchin mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

@QiluXie QiluXie Awaiting requested review from QiluXie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caando @QiluXie @kishore03109