feat(nps): update UI #1370
feat(nps): update UI #1370
Conversation
|
!run-chromatic |
There was a problem hiding this comment.
More or less ok with the code, but here is my assumption of the flow here:
Currently, the REACT_APP_SHOW_NPS_FORM is set to true, and the NPS forms are shown once every 3 (or 1 or 4) week. When we set the env var to be false, the timer in their local storage does not reset. Ie, this would mean that when ops/product wants to get feedback, setting the value to true does not guarantee that we will be showing NPS to our users. (at the worst case the turnaround time is 4 weeks). as long as ops is aware of this flow this is fine (and tbh this flow is intuitive since we dont want to spam users with the feedback)
If this assumption is not correct, please dismiss my review
other nits: if prs are to be reviewed with relevant BE prs, please link them ya! my assumption here is that the relevant be pr is this, let me know if this is wrong!
| } from "@chakra-ui/react" | ||
| import { PropsWithChildren } from "react" | ||
|
|
||
| const RATING_SCALE = 11 |
There was a problem hiding this comment.
damn TIL NPS starts from 0
| const [lastSeen, setLastSeen] = useFeedbackStorage() | ||
| // NOTE: Either this is the first time the user has ever seen the survey | ||
| // or that the user has seen the survey but it has been more than 3 weeks. | ||
| // Because we toggle the survey on every month, this indicates that they should |
There was a problem hiding this comment.
hmm shall we be precise on the frequency haha
7 days vs 3 weeks vs 1 mth
There was a problem hiding this comment.
2 things here - frequency of survey is 1 month, duration is 1 wek
There was a problem hiding this comment.
@kishore03109 add a bit of explanation of my understanding here:
- duration of survey is 1 week defined by the constant
NPS_SURVEY_DURATION - the frequency of survey is controlled by manually turning on and off of the env var
REACT_APP_SHOW_NPS_FORM
@seaerchin correct me if I'm wrong.
seaerchin
force-pushed
the
fix/upgradeDesignSystem
branch
from
6f6d921 to
37fb178
Compare
|
!run-chromatic |
seaerchin
force-pushed
the
feat/update-nps-ui
branch
from
bee00a9 to
cc0fcce
Compare
NOTE: There's an extra commit because the previous PR was merged into
developPlease skip
useFeedbackDisclosureTo be reviewed w/ BE PR (here)
Problem
Previously we were using FormSG as a backend. This updates the nps ui to the one in the figma and hits a backend endpoint.
Solution
LoginContextso we know theuserTypeTests
Notes
This PR is blocked by the design system upgrade