Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(0.33.0): merge to dev #1334

Merged
merged 1 commit into from
Jul 6, 2023
Merged

release(0.33.0): merge to dev #1334

merged 1 commit into from
Jul 6, 2023

Conversation

seaerchin
Copy link
Contributor

What's Changed

Full Changelog: v0.32.0...v0.33.0

@mergify
Copy link

mergify bot commented Jul 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #1335. Mergify cannot evaluate rules on this PR. ⚠️

@seaerchin seaerchin requested review from kishore03109 and a team July 6, 2023 06:11
@seaerchin
Copy link
Contributor Author

seaerchin commented Jul 6, 2023

Tests

Fix/is 276 toast rerender #1333 @kishore03109

Main sources of errors

  • Collaborators flow
    • Add new collaborator -> only a single success toast should show up
    • Known bug (not being fixed in this release) - this toast cannot be closed and will not go away until you close the modal
  • Settings flow
    • Modify any setting -> save -> only a single success toast should show up
    • Known bug (not being fixed in this release) - subsequently editing any field without saving after the toast has disappeared will cause a new toast to appear

manually verified by @kishore03109

@seaerchin
Copy link
Contributor Author

seaerchin commented Jul 6, 2023

Tests

#1325 @seaerchin

Tests

  • go to kishore-test-email-login (currently is the only whitelisted repo in the frontend)
  • go to /sites/kishore-test-email-login and click on go to launch pad
  • follow through the steps,
  • put a valid domain (eg. test.isomer.gov.sg), and select anything for the domain nature and the usage of www
  • click the next button, check on all the steps
  • wait for 2 minutes, should be able to see the DNS records
    something similar to this:
    image

@seaerchin
Copy link
Contributor Author

seaerchin commented Jul 6, 2023

Tests

#1324 @seaerchin

  • go to /<site>/siteLaunchPad for a site without site launch (kishore-test is one)
  • should be redirected to /dashboard
  • should see an error toast

cc @kishore03109 if this test spec is ok jus strikethough this
@seaerchin yup, manaully verified this behvaiour on staging too

@seaerchin seaerchin temporarily deployed to staging July 6, 2023 06:21 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging July 6, 2023 06:23 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging July 6, 2023 06:24 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging July 6, 2023 06:25 — with GitHub Actions Inactive
@kishore03109
Copy link
Contributor

kishore03109 commented Jul 6, 2023

Tests

817 @seaerchin

  • go to any test repo
  • change a file name to 2012.09.19.BT_blah.pdf
  • Login and rename the file name directly via the cms

Copy link
Contributor

@kishore03109 kishore03109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wah i wonder why the previous change logs keep being modified :/

@seaerchin
Copy link
Contributor Author

verified failing e2e tests on staging

@seaerchin seaerchin merged commit b70f43f into develop Jul 6, 2023
@seaerchin seaerchin deleted the release/v0.33.0 branch July 6, 2023 08:43
@alexanderleegs alexanderleegs mentioned this pull request Jul 12, 2023
@mergify mergify bot requested a review from a team August 5, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants