Chore/modify e slint rule #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishv7
reviewed
Jun 28, 2023
CHANGELOG.md
Outdated
| @@ -4,8 +4,16 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
There was a problem hiding this comment.
can rebase to drop these commits?
There was a problem hiding this comment.
opps sorry never see properly, done
| @@ -42,7 +42,7 @@ | |||
| "rules": { | |||
| "no-shadow": "off", | |||
| "@typescript-eslint/no-shadow": "error", | |||
| "react/jsx-props-no-spreading": "warn", | |||
| "react/jsx-props-no-spreading": "off", | |||
kishore03109
force-pushed
the
chore/modifyESlintRule
branch
from
f57738c to
d8cbca3
Compare
harishv7
approved these changes
Jun 28, 2023
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I think as a team we have been ok with ignoring this rule in favour of cleaner code (ie we dont have to manually type out the props). This can be reflected by the mere fact that there are many files with this rule being ignored.
Rather than having multiple ignore warnings, this PR changes that to allow such eslint rules to pass, rather than us needed to ignore this.
Solution
change eslint.rc