Fix/is 276 toast rerender #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
approved these changes
Jul 5, 2023
kishore03109
approved these changes
Jul 5, 2023
| @@ -12,7 +12,7 @@ const retrieveThirdNavOptions = async ( | |||
| collectionName, | |||
| isExistingCollection | |||
| ) => { | |||
| const errorToast = useErrorToast | |||
| const errorToast = useErrorToast() | |||
There was a problem hiding this comment.
huh so this never worked :sadge:
| export const useErrorToast = (): UseToastReturn => | ||
| useToast({ | ||
| // Not specifying return type because type is in the argument | ||
| const useIsomerToast = (args: UseToastProps) => { |
There was a problem hiding this comment.
wah I think we need to define a return type here, but fell into a rabbit hole for this cuz we got a version mismatch between chakra and design system.
specifically, danger doesnt exist anymore, should be error now, but design system is lagging behind, actually not sure if this is already a bug in prod :sadge:
Rather than putting this, could you create a ticket and assign it to me? is related to the design system changes
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with multiple rerenders of the toast components - the behaviour of react-hook-form and react-query seem to have changed after our dependencies update, and this caused issues for all of our toasts which were contained within
useEffect, as the component would get rerendered, which changed the reference totoastand triggered the useEffect again.The solution to this issue is to modify the toasts to use the
idparam - this prevents duplicate toasts from appearing (link). The components which make use of toasts have been modified to support this.Also resolves IS-284 once the privatisation PR has been rebased onto this one.