refactor(ff): make site launch flag a bool flag #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
reviewed
Oct 9, 2023
there's a form for prod ops to fill up that triggers a clone |
|
@seaerchin wait so to be clear, post email migration of sites there needs to a manual sending submission of this form by eng/ops? |
harishv7
reviewed
Oct 12, 2023
seaerchin
force-pushed
the
feat/is-579-ggs-gb
branch
from
d18a23f to
7880953
Compare
harishv7
approved these changes
Oct 24, 2023
dcshzj
added a commit
that referenced
this pull request
Oct 26, 2023
* refactor(formsg-site-clone): remove and add to site creation (#971) * refactor(formsg-site-clone): remove and add to site creation * fix(formsgsitecreation): fixed rename betrayal by vvscode * refactor(formsgsitecreation): cloen only on email * refactor(ff): make site launch flag a bool flag (#958) * refactor(ff): make flag a bool flag * refactor(flags): update ff * refactor(reposervice): remove function * refactor(routehandler): remove function * fix(routehandler): rename ff * fix(reposervice): update test spec * Feat/quickie/site-create-form (#985) * feat(git clone): add branch * feat(db): update deployments table * fix(reposService): fix git commands * fix(reposService): cleaner code * fix(tests): fix failing tests * style(deploymentService): better error messages * chore(auth): upgrade auth redirect endpoint to use v2 (#986) * 0.50.0 --------- Co-authored-by: Kishore <[email protected]> Co-authored-by: seaerchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now, our GGS flag adopts a two tiered approach - first, we get the list of repos from growthbook then we validate based on that.
This is a whitelist approach, where we add sites as they shift to ggs. This is effortful and going forward, we want to make our flag a blacklist approach, where we allow sites by default until we need to blacklist them.
Solution
Add new flag on growthbook that returns a boolean value checking if the user type is email and whether site is blacklisted. (it's true if user is email && site isn't blacklisted)
Deploy notes
these steps have to be done pre deploy
these steps have to be done post deploy
is_ggs_enabledon production