refactor(ff): make site launch flag a bool flag

src/constants/featureFlags.ts

@@ -1,4 +1,4 @@
 export const FEATURE_FLAGS = {
-  GGS_WHITELISTED_REPOS: "ggs_whitelisted_repos",
   IS_BUILD_TIMES_REDUCTION_ENABLED: "is_build_times_reduction_enabled",
+  IS_GGS_ENABLED: "is_ggs_enabled",
 } as const

src/middleware/routeHandler.js

@@ -25,16 +25,6 @@ const gitFileSystemService = new GitFileSystemService(
   new SimpleGit({ maxConcurrentProcesses: MAX_CONCURRENT_GIT_PROCESSES })
 )
 
-const isRepoWhitelisted = (siteName, ggsWhitelistedRepos) => {
-  // TODO: adding log to simplify debugging, to be removed after stabilising
-  logger.info(
-    `Checking if ${siteName} is GGS whitelisted: ${ggsWhitelistedRepos.includes(
-      siteName
-    )}`
-  )
-  ggsWhitelistedRepos.includes(siteName)
-}
-
 const handleGitFileLock = async (repoName, next) => {
   const result = await gitFileSystemService.hasGitFileLock(repoName)
   if (result.isErr()) {
@@ -74,23 +64,15 @@ const attachWriteRouteHandlerWrapper = (routeHandler) => async (
   const { siteName } = req.params
   const { growthbook } = req
 
-  let ggsWhitelistedRepos = { repos: [] }
-  if (growthbook) {
-    ggsWhitelistedRepos = growthbook.getFeatureValue(
-      FEATURE_FLAGS.GGS_WHITELISTED_REPOS,
-      {
-        repos: [],
-      }
-    )
-  }
-
   let isGitAvailable = true
-  // only check git file lock if the repo is whitelisted
-  if (isRepoWhitelisted(siteName, ggsWhitelistedRepos.repos)) {
+
+  // only check git file lock if the repo is ggs enabled
+  if (growthbook?.getFeatureValue(FEATURE_FLAGS.IS_GGS_ENABLED, false)) {
     isGitAvailable = await handleGitFileLock(siteName, next)
   }
 
   if (!isGitAvailable) return
+
   try {
     await lock(siteName)
   } catch (err) {
@@ -102,6 +84,7 @@ const attachWriteRouteHandlerWrapper = (routeHandler) => async (
     await unlock(siteName)
     next(err)
   })
+
   try {
     await unlock(siteName)
   } catch (err) {
@@ -120,19 +103,9 @@ const attachRollbackRouteHandlerWrapper = (routeHandler) => async (
   const { accessToken } = userSessionData
   const { growthbook } = req
 
-  let ggsWhitelistedRepos = { repos: [] }
-  if (growthbook) {
-    ggsWhitelistedRepos = growthbook.getFeatureValue(
-      FEATURE_FLAGS.GGS_WHITELISTED_REPOS,
-      {
-        repos: [],
-      }
-    )
-  }
-
-  const shouldUseGitFileSystem = isRepoWhitelisted(
-    siteName,
-    ggsWhitelistedRepos.repos
+  const shouldUseGitFileSystem = !!growthbook?.getFeatureValue(
+    FEATURE_FLAGS.IS_GGS_ENABLED,
+    false
   )
 
   const isGitAvailable = await handleGitFileLock(siteName, next)

src/services/db/RepoService.ts

@@ -84,32 +84,6 @@ export default class RepoService extends GitHubService {
     this.githubCommitService = gitHubCommitService
   }
 
-  getGgsWhitelistedRepos(
-    growthbook: GrowthBook<FeatureFlags> | undefined
-  ): string[] {
-    if (!growthbook) return []
-
-    const whitelistedGgsRepos = growthbook.getFeatureValue(
-      FEATURE_FLAGS.GGS_WHITELISTED_REPOS,
-      { repos: [] }
-    )
-    return whitelistedGgsRepos.repos
-  }
-
-  isRepoGgsWhitelisted(
-    repoName: string,
-    ggsWhitelistedRepos: string[]
-  ): boolean {
-    // TODO: Adding for initial debugging if required. Remove once stabilised
-    logger.info(
-      `Evaluating if ${repoName} is GGS whitelisted: ${ggsWhitelistedRepos.includes(
-        repoName
-      )}`
-    )
-
-    return ggsWhitelistedRepos.includes(repoName)
-  }
-
   getCommitDiff(siteName: string, base?: string, head?: string) {
     return ReviewApi.getCommitDiff(siteName, base, head)
   }
@@ -202,9 +176,9 @@ export default class RepoService extends GitHubService {
     }
   ): Promise<{ sha: string }> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info(
@@ -231,9 +205,9 @@ export default class RepoService extends GitHubService {
     { fileName, directoryName }: { fileName: string; directoryName?: string }
   ): Promise<GitFile> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info("Reading file from local Git file system")
@@ -266,9 +240,9 @@ export default class RepoService extends GitHubService {
 
     // fetch from local disk
     if (
-      this.isRepoGgsWhitelisted(
-        siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info(
@@ -312,9 +286,9 @@ export default class RepoService extends GitHubService {
   ): Promise<GitDirectoryItem[]> {
     const defaultBranch = STAGING_BRANCH
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info("Reading directory from local Git file system")
@@ -355,9 +329,9 @@ export default class RepoService extends GitHubService {
     let dirContent: GitDirectoryItem[] = []
 
     if (
-      this.isRepoGgsWhitelisted(
-        siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       const result = await this.gitFileSystemService.listDirectoryContents(
@@ -408,9 +382,9 @@ export default class RepoService extends GitHubService {
     }
   ): Promise<GitCommitResult> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       return this.gitFileCommitService.update(sessionData, {
@@ -442,9 +416,9 @@ export default class RepoService extends GitHubService {
     }
   ): Promise<void> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       await this.gitFileCommitService.deleteDirectory(sessionData, {
@@ -474,9 +448,9 @@ export default class RepoService extends GitHubService {
     }
   ): Promise<void> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       await this.gitFileCommitService.delete(sessionData, {
@@ -503,9 +477,9 @@ export default class RepoService extends GitHubService {
     message?: string
   ): Promise<GitCommitResult> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       return this.gitFileCommitService.renameSinglePath(
@@ -534,9 +508,9 @@ export default class RepoService extends GitHubService {
     message?: string
   ): Promise<GitCommitResult> {
     if (
-      this.isRepoGgsWhitelisted(
-        sessionData.siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       return this.gitFileCommitService.moveFiles(
@@ -573,9 +547,9 @@ export default class RepoService extends GitHubService {
   ): Promise<GitHubCommitData> {
     const { siteName } = sessionData
     if (
-      this.isRepoGgsWhitelisted(
-        siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info(
@@ -629,9 +603,9 @@ export default class RepoService extends GitHubService {
   ): Promise<void> {
     const { siteName } = sessionData
     if (
-      this.isRepoGgsWhitelisted(
-        siteName,
-        this.getGgsWhitelistedRepos(sessionData.growthbook)
+      sessionData.growthbook?.getFeatureValue(
+        FEATURE_FLAGS.IS_GGS_ENABLED,
+        false
       )
     ) {
       logger.info(