Feat/quickie/site-create-form #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
approved these changes
Oct 25, 2023
| const amplifyInfo = amplifyResult.value | ||
|
|
||
| if (amplifyStagingLiteResult.isErr()) { | ||
| logger.error(`Amplify set up error: ${amplifyStagingLiteResult.error}`) |
There was a problem hiding this comment.
Should we differentiate between this error message and the previous one? So that it is easier at a glance to know which app creation failed.
There was a problem hiding this comment.
fair point 9fbbd47
| fs.rmSync(`${stgLiteDir}/.git`, { recursive: true, force: true }) | ||
|
|
||
| // Prepare git repo | ||
|
|
dcshzj
added a commit
that referenced
this pull request
Oct 26, 2023
* refactor(formsg-site-clone): remove and add to site creation (#971) * refactor(formsg-site-clone): remove and add to site creation * fix(formsgsitecreation): fixed rename betrayal by vvscode * refactor(formsgsitecreation): cloen only on email * refactor(ff): make site launch flag a bool flag (#958) * refactor(ff): make flag a bool flag * refactor(flags): update ff * refactor(reposervice): remove function * refactor(routehandler): remove function * fix(routehandler): rename ff * fix(reposervice): update test spec * Feat/quickie/site-create-form (#985) * feat(git clone): add branch * feat(db): update deployments table * fix(reposService): fix git commands * fix(reposService): cleaner code * fix(tests): fix failing tests * style(deploymentService): better error messages * chore(auth): upgrade auth redirect endpoint to use v2 (#986) * 0.50.0 --------- Co-authored-by: Kishore <[email protected]> Co-authored-by: seaerchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Moving forward to support quickie, all sites need to have 2 branches,
staging+staging-liteAND 2 amplify apps. This modifies the site create form to allow this to happen.Closes [insert issue #]