Fix/image endpoints for nested images #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the ImageFile class so that the base endpoint reflects the nested directory of an image, instead of assuming that the base endpoint is the top level 'images' directory
… targets This commit updates the image upload endpoint to use the ImageFile class type so that it's consistent with the image reading endpoint. In doing so, we also allow users to create images in nested directories.
This commit updates the image renaming endpoint to use the ImageFile class, and to deal with nested images.
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, our backend endpoints for images cannot handle changes to images in nested directories. That's because the endpoints that we're hitting on GitHub assume that there is only one directory where we store all images: the
imagesdirectory in the root of the repo.This PR updates the following endpoints:
/:siteName/images/:siteName/images/:imageName/:siteName/images/:imageName/rename/:newImageNameSo that we can read, create, and rename individual images that are in nested directories. I also updated these endpoints to use the
MediaFile(renamed fromImageFile) class instead of theFileclass that was being used before.As part of this PR, changes were also made to the
MediaFileclass so that theImageTypeclass used accepts an argument in its constructor which determines the base API endpoint. This allows us to set the base endpoint to be a nested directory instead of the rootimagesdirectory.