Fix/media file class #168
Merged
Fix/media file class #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the ImageFile class so that the base endpoint reflects the nested directory of an image, instead of assuming that the base endpoint is the top level 'images' directory
… targets This commit updates the image upload endpoint to use the ImageFile class type so that it's consistent with the image reading endpoint. In doing so, we also allow users to create images in nested directories.
This commit updates the image renaming endpoint to use the ImageFile class, and to deal with nested images.
alexanderleegs
force-pushed
the
fix/imageFile-class
branch
from
9d8b937 to
d8cff8c
Compare
* Feat: add mediaSubfolder class * Feat: add routes for media subfolder creation, deletion, and renaming * Fix: retrieve git tree recursively and filter for delete and rename * Feat: add endpoints for file subfolders (#169) * Feat: extend mediafile and mediasubfolder to handle files * Feat: update documents endpoint * Fix: throw error on unknown media type * Nit: add comments for determining directory and file name * Fix: throw correct conflict error for same file name
Merged
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* feat: modify ImageFile class to retrieve nested files This commit modifies the ImageFile class so that the base endpoint reflects the nested directory of an image, instead of assuming that the base endpoint is the top level 'images' directory * fix: update ImageFile creation method to accept nested directories as targets This commit updates the image upload endpoint to use the ImageFile class type so that it's consistent with the image reading endpoint. In doing so, we also allow users to create images in nested directories. * fix: update image renaming to handle nested image files This commit updates the image renaming endpoint to use the ImageFile class, and to deal with nested images. * chore: rename ImageFile class to MediaFile` * Feat new endpoints for media subfolders (#166) * Feat: add mediaSubfolder class * Feat: add routes for media subfolder creation, deletion, and renaming * Fix: retrieve git tree recursively and filter for delete and rename * Feat: add endpoints for file subfolders (#169) * Feat: extend mediafile and mediasubfolder to handle files * Feat: update documents endpoint * Fix: throw error on unknown media type * Nit: add comments for determining directory and file name * Fix: throw correct conflict error for same file name Co-authored-by: kwajiehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes we require to support the nested images and files layout on the cms frontend.