Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/image file class #161

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Fix/image file class #161

merged 4 commits into from
Apr 22, 2021

Conversation

alexanderleegs
Copy link
Contributor

This PR is a duplicate of #154, as we have decided to not merge this feature into master yet.

This commit modifies the ImageFile class so that the base endpoint
reflects the nested directory of an image, instead of assuming that
the base endpoint is the top level 'images' directory
… targets

This commit updates the image upload endpoint to use the ImageFile
class type so that it's consistent with the image reading endpoint.
In doing so, we also allow users to create images in nested directories.
This commit updates the image renaming endpoint to use the ImageFile
class, and to deal with nested images.
@alexanderleegs alexanderleegs requested a review from gweiying April 20, 2021 10:14
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alexanderleegs alexanderleegs merged commit 77799f5 into develop Apr 22, 2021
@alexanderleegs alexanderleegs deleted the fix/imageFile-class branch April 22, 2021 06:34
@alexanderleegs alexanderleegs restored the fix/imageFile-class branch April 30, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants