Release/0.60.0 #1074
Merged
Release/0.60.0 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release/0.59.0
* feat(docker): add docker config * refactor(package): update command * fix(dockerfile): remove extra copy * refactor(dockerfile): update docker file * fix(docker): update dockerfile to have git + efs vol
* removed all instances of any from GitHubService.ts * added more explicit types to gitTree and message * removed unnecessary gitTree declartion as string
**NOTE: Setup changes required after this PR is merged!!!** ## Problem Docker setup previously couldn't push to github due to lacking ssh creds + git config. This PR solves that issue. Closes [insert issue #] ## Solution - copy over stuff from a local `.ssh` folder into docker - add git + ssh clients - add github to trusted hosts ## Setup instructions - This assumes that your `git.config` is **global**; if this isn't so, remedy by following the instructions [here](https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup) - Copy over your `ssh` creds for github into a `.ssh` folder **rooted inside our workdir** (that's `isomercms-backend/`). Name the public key `github.pub` and hte private key `github` - ensure that your local `DB_URI` is `postgres://isomer:password@postgres:5432/isomercms_dev` (updated alr in 1pw)
## Problem CI tests were failing as `docker compose up` is timing out despite working fine on local ## Solution don't use docker compose, just pass a command directly
…in repoService.ts (#1066) * replaced all instances of any with explict types in repoService.ts * remove unnecessary return type and unused import * refactored changeRepoPrivacy to use ResultAsync properly * made several properties optional in GithubRepoInfo * fixed test
* feat(dockerfile): migrate fetching keys to script too * feat(dockerfile): rework and add dockerignore
* fix: add conditional sha calc * fix(media): remove unused query and set small limit * fix: remove debug statements * fix: refactor code * fix: add sha for listDirectoryContents --------- Co-authored-by: Hsu Zhong Jun <[email protected]>
Merged
seaerchin
approved these changes
Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.60.0
#1072#1070#1066#1069#1067#1063#1059#1061cefefc13da4d1cf36c524