Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): setup github stuff to be parity with efs #1067

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Dec 19, 2023

NOTE: Setup changes required after this PR is merged!!!

Problem

Docker setup previously couldn't push to github due to lacking ssh creds + git config. This PR solves that issue.

Closes [insert issue #]

Solution

  • copy over stuff from a local .ssh folder into docker
  • add git + ssh clients
  • add github to trusted hosts

Setup instructions

  • This assumes that your git.config is global; if this isn't so, remedy by following the instructions here
  • Copy over your ssh creds for github into a .ssh folder rooted inside our workdir (that's isomercms-backend/). Name the public key github.pub and hte private key github
  • ensure that your local DB_URI is postgres://isomer:password@postgres:5432/isomercms_dev (updated alr in 1pw)

@seaerchin seaerchin requested review from harishv7 and a team December 19, 2023 09:12
@seaerchin seaerchin merged commit 53f6769 into develop Dec 20, 2023
9 of 10 checks passed
@mergify mergify bot deleted the fix/docker branch December 20, 2023 04:07
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants