ref(ts migration): replaced all instances of any with explicit types in repoService.ts #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
reviewed
Dec 20, 2023
dcshzj
approved these changes
Dec 20, 2023
QiluXie
changed the title
QiluXie
force-pushed
the
IS-836-remove-instance-of-any-from-reposervice
branch
from
1cb950b to
7010970
Compare
|
CI passed, all green. Merging now. |
mergify
bot
deleted the
IS-836-remove-instance-of-any-from-reposervice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes IS-836
There are a lot of instances of type
anyin the filerepoService.ts, and we need to replace them with explicit types to ensure type safety.Solution
Replaced all instances of type
anyinrepoService.tsBreaking Changes
Improvements:
anyinrepoService.tsTests
CI test to confirm no error in type checking