Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reposervice fix cwd #1004

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

harishv7
Copy link
Contributor

@harishv7 harishv7 commented Nov 1, 2023

Problem

By right we are supposed to use root = false, to quite the doc

.cwd({ path, root = false }) Sets the working directory for all future commands either in the current chain of commands (where root is omitted or set to false) or in the main instance (where root is true).

Ran this agains this against ~30 sites at one go, no errors like the ones we previously observed
Screenshot 2023-11-01 at 5 29 23 PM

Tests

  • e2e tests for GGs
  • For a GGs site in staging, able to CRUD on pages + CRUD on images

@harishv7 harishv7 requested a review from kishore03109 November 1, 2023 07:38
Copy link
Contributor

@kishore03109 kishore03109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our git file system service also need changes

@kishore03109
Copy link
Contributor

kishore03109 commented Nov 1, 2023

lets branch off from last week's release + create 2 prs (one for dev, one to master) to do a hotfix today

also have we load tested this against multiple chained steps? (or you think no need)

@kishore03109 kishore03109 merged commit 44663eb into develop Nov 1, 2023
8 checks passed
@mergify mergify bot deleted the IS-723-hotfix-simple-git-cwd-flags branch November 1, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants