Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are facing issues with files being deleted for seemingly innocuous deletes from certain folders. simple git supports chaining, but note that each process is async, which they have have queue that is awaited
But hor, the var cwd is shared, rather than attached to each process that is in the queue.
This means that at production level, we cannot afford to use their simple git’s chaining at all, and it will lead to all sorts of concurrency issues that we have no control over.
I think the reason why quickie affects this is because when creates are done, they are done almost simultaneously to two branches, so while this bug always existed in production, its hard to replicate this unless two git processes with this chaining occured at the exact same time, which is exactly kinda what happens with quickie
Tests
I am able to replicate this locally when running against ~30 repos.
Before
After