Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple git): avoid chaining #1003

Closed
wants to merge 1 commit into from

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 1, 2023

Problem

We are facing issues with files being deleted for seemingly innocuous deletes from certain folders. simple git supports chaining, but note that each process is async, which they have have queue that is awaited
But hor, the var cwd is shared, rather than attached to each process that is in the queue.

This means that at production level, we cannot afford to use their simple git’s chaining at all, and it will lead to all sorts of concurrency issues that we have no control over.
I think the reason why quickie affects this is because when creates are done, they are done almost simultaneously to two branches, so while this bug always existed in production, its hard to replicate this unless two git processes with this chaining occured at the exact same time, which is exactly kinda what happens with quickie

Tests

I am able to replicate this locally when running against ~30 repos.

Before

Screenshot 2023-11-01 at 9 49 42 AM

After

Screenshot 2023-11-01 at 9 46 41 AM

@kishore03109
Copy link
Contributor Author

closing this as better fix is #1004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant