Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reposService): simple git path cwd #1005

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix(reposService): simple git path cwd #1005

merged 1 commit into from
Nov 1, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 1, 2023 •
edited
Loading

forgot to add in one more to #1004

no more .cwd(path) signatures found

@kishore03109 kishore03109 requested a review from a team November 1, 2023 09:33
seaerchin
seaerchin approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker - we should just override the property if required cos this is damn easy to forget

@kishore03109 kishore03109 merged commit 0d9585b into develop Nov 1, 2023
14 checks passed
@mergify mergify bot deleted the fix/simplegit branch November 1, 2023 10:12
This was referenced Nov 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @seaerchin