fix(application-system): Fix accident notification data #16954
Conversation
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16954 +/- ##
==========================================
- Coverage 36.41% 36.41% -0.01%
==========================================
Files 6898 6898
Lines 144879 144883 +4
Branches 41410 41410
==========================================
Hits 52755 52755
- Misses 92124 92128 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification-v2.utils.ts (2)
374-382: LGTM: Clean destructuring implementationThe code effectively extracts company and representative information using object destructuring, improving readability while maintaining null safety.
Consider adding type annotations to the destructured objects for better type safety:
-const { companyName, companyNationalId } = answers.juridicalPerson -const { name, email, phoneNumber } = answers.applicant +const { companyName, companyNationalId }: { companyName: string; companyNationalId: string } = answers.juridicalPerson +const { name, email, phoneNumber }: { name: string; email: string; phoneNumber: string } = answers.applicant
393-404: LGTM: Consistent implementation of employer data handlingThe changes maintain a consistent pattern of data extraction and null safety throughout the function.
Consider adding validation for the destructured values:
const { name: companyName = '', nationalRegistrationId: companyNationalId = '', } = companyInfo const { name, email, phoneNumber } = representative + +// Add validation to ensure required fields are present +if (!companyName || !companyNationalId) { + throw new Error('Missing required company information') +}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification-v2.utils.ts(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification-v2.utils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
📓 Learnings (1)
libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification-v2.utils.ts (1)
Learnt from: HjorturJ
PR: island-is/island.is#16111
File: libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification.utils.spec.ts:210-361
Timestamp: 2024-11-12T15:15:20.157Z
Learning: In `accident-notification.utils.spec.ts`, the helper functions `getDefaultAttachments` and `getFullBasicAnswers` should not be modified to accept parameters for customizing returned data.
🔇 Additional comments (1)
libs/application/template-api-modules/src/lib/modules/templates/accident-notification/accident-notification-v2.utils.ts (1)
53-54: LGTM: Enum mapping correction
The fix properly aligns the reporting entity mappings, resolving the switched values issue mentioned in the PR objectives.
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 34.92s Total Time |
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
Attach a link to issue if relevant
What
Fix switched values in accident-notification
Why
So the correct values will be in the correct place
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor