-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(my-pages): health vaccination tags & locale #16567
Conversation
WalkthroughThe changes in this pull request primarily focus on enhancing the handling of vaccination data by incorporating locale-specific parameters across various components. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16567 +/- ##
========================================
Coverage 36.53% 36.54%
========================================
Files 6892 6880 -12
Lines 143892 143241 -651
Branches 41014 40897 -117
========================================
- Hits 52578 52342 -236
+ Misses 91314 90899 -415
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 84 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 4 Passed Test Services
|
…s/island.is into my-pages/vaccinations-tag-color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COOL 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (15)
libs/service-portal/health/src/screens/Vaccinations/Vaccinations.graphql (1)
1-1
: Consider adding parameter documentation.To improve maintainability, consider adding a description for the locale parameter using GraphQL's built-in documentation syntax.
+# Locale parameter determines the language of vaccination details query getVaccinations($locale: String) {
🧰 Tools
🪛 eslint
[error] 1-1: Parsing error: Unexpected token getVaccinations
libs/api/domains/health-directorate/src/lib/models/enums.ts (1)
3-12
: Consider splitting the enum based on distinct status conceptsThe current enum mixes different types of statuses (validity, completion, documentation). This could lead to confusion about which values are mutually exclusive.
Consider splitting into separate enums:
export enum VaccinationValidityStatus { Valid = 'valid', Expired = 'expired' } export enum VaccinationCompletionStatus { Complete = 'complete', Incomplete = 'incomplete' } export enum VaccinationDocumentationStatus { Documented = 'documented', Undocumented = 'undocumented', Rejected = 'rejected', Undetermined = 'undetermined' }libs/api/domains/health-directorate/src/lib/utils/mappers.ts (1)
4-6
: Consider adding documentation and enhancing type safetyTo improve maintainability and type safety:
- Add JSDoc documentation explaining the mapping logic and why certain statuses map to others
- Consider using TypeScript's exhaustive type checking to ensure all enum cases are handled
+/** + * Maps health directorate vaccination status to internal vaccination status enum + * @param status - The vaccination status from the health directorate API + * @returns The corresponding internal vaccination status + */ export const mapVaccinationStatus = ( status?: DiseaseVaccinationDtoVaccinationStatusEnum, ): VaccinationStatusEnum => {libs/api/domains/health-directorate/src/lib/models/vaccinations.model.ts (1)
59-60
: LGTM! Good improvement in type safety.The change from string to
VaccinationStatusEnum
enhances type safety and provides better IDE support. The nullable flag maintains backward compatibility.Consider adding JSDoc comments to document the possible enum values for better developer experience:
+ /** + * The vaccination status. + * @see VaccinationStatusEnum for possible values + */ @Field(() => VaccinationStatusEnum, { nullable: true }) status?: VaccinationStatusEnumlibs/clients/health-directorate/src/lib/clients/vaccinations/vaccinations.service.ts (1)
33-35
: Consider enhancing debug logs with additional contextWhile changing to debug level is appropriate, consider adding more context to help with debugging:
- this.logger.debug('No vaccines returned', { + this.logger.debug('No vaccines returned from API', { category: LOG_CATEGORY, + auth: { hasAuth: !!auth }, }) - this.logger.debug('No vaccines diseases returned', { + this.logger.debug('No vaccine diseases returned from API', { category: LOG_CATEGORY, + locale, + auth: { hasAuth: !!auth }, })Also applies to: 56-58
libs/service-portal/health/src/screens/Vaccinations/VaccinationsWrapper.tsx (2)
19-23
: Consider enhancing error handling with specific error typesWhile the error handling works, it could benefit from more specific error types to handle different scenarios (network errors, validation errors, etc.) differently.
Example enhancement:
interface VaccinationError { type: 'NETWORK_ERROR' | 'VALIDATION_ERROR' | 'NOT_FOUND'; message: string; } // Usage in component const handleError = (error: VaccinationError) => { switch (error.type) { case 'NETWORK_ERROR': return <Problem error={error} variant="network" />; // ... handle other cases } };
Line range hint
26-27
: Add explicit typing to filter callbacksThe filter callbacks could benefit from explicit typing to improve type safety and code maintainability.
- const general = vaccinations?.filter((x) => x.isFeatured) - const other = vaccinations?.filter((x) => !x.isFeatured) + const general = vaccinations?.filter((x: { isFeatured: boolean }) => x.isFeatured) + const other = vaccinations?.filter((x: { isFeatured: boolean }) => !x.isFeatured)libs/service-portal/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx (2)
37-37
: Simplify the null check condition.The optional chaining operator after the null check is redundant since we've already verified that
data
exists.- if (!data || data?.length === 0) + if (!data || data.length === 0)
Line range hint
53-101
: Consider type narrowing for better type safety.Since we've verified
data
exists before mapping, we can narrow its type for better TypeScript inference. Also, the explicitundefined
in the tag selector is redundant as optional chaining already returnsundefined
when the value is null/undefined.- data.map((item, i) => ({ + (data as HealthDirectorateVaccination[]).map((item, i) => ({ id: item?.id ?? `${i}`, name: item?.name ?? '', vaccine: item?.name ?? '', date: formatDate(item?.lastVaccinationDate) ?? '', children: ( // ... children content ... ), status: item?.statusName ?? '', - tag: tagSelector(item?.status ?? undefined), + tag: tagSelector(item?.status), })) ?? []libs/api/domains/health-directorate/src/lib/health-directorate.service.ts (1)
80-83
: Consider extracting locale conversion logicThe locale conversion logic is repeated across multiple methods. Consider extracting it into a shared utility function for better maintainability and consistency.
+ private convertLocale(locale: Locale): string { + return locale === 'is' ? 'is' : 'en' + } async getVaccinations( auth: Auth, locale: Locale, ): Promise<Vaccinations | null> { const data = await this.vaccinationApi.getVaccinationDiseaseDetail( auth, - locale === 'is' ? 'is' : 'en', + this.convertLocale(locale), )libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json (1)
Line range hint
1-1000
: Consider documenting the locale parameter impact.While the implementation is correct, consider adding descriptions to the locale parameters to clarify their effect on the responses.
Apply this diff to enhance documentation:
{ "name": "locale", "required": false, "in": "query", + "description": "Language code for localized content. Affects disease names and descriptions in the response.", "schema": { "enum": ["en", "is"], "type": "string" } }
libs/service-portal/health/src/utils/tagSelector.ts (4)
12-17
: Simplify switch cases by grouping statuses with the same return valueYou can reduce code duplication and enhance readability by grouping cases that return the same
TagVariant
.Apply this diff to group statuses returning
'blue'
:switch (status) { - case HealthDirectorateVaccinationStatusEnum.complete: - return 'blue' - case HealthDirectorateVaccinationStatusEnum.expired: - return 'blue' - case HealthDirectorateVaccinationStatusEnum.incomplete: - return 'blue' + case HealthDirectorateVaccinationStatusEnum.complete: + case HealthDirectorateVaccinationStatusEnum.expired: + case HealthDirectorateVaccinationStatusEnum.incomplete: + return 'blue'
18-23
: Simplify switch cases by grouping statuses with the same return valueSimilarly, group the statuses that return
'purple'
.Apply this diff to group these cases:
case HealthDirectorateVaccinationStatusEnum.incomplete: return 'blue' - case HealthDirectorateVaccinationStatusEnum.rejected: - return 'purple' - case HealthDirectorateVaccinationStatusEnum.undetermined: - return 'purple' - case HealthDirectorateVaccinationStatusEnum.undocumented: - return 'purple' + case HealthDirectorateVaccinationStatusEnum.rejected: + case HealthDirectorateVaccinationStatusEnum.undetermined: + case HealthDirectorateVaccinationStatusEnum.undocumented: + return 'purple'
9-9
: Consider removing the redundant undefined checkSince the
switch
statement's default case returns'blue'
, the initial check forstatus
being undefined may be unnecessary.Apply this diff to simplify the function:
- if (!isDefined(status)) return 'blue' switch (status) { ... default: return 'blue'
This would streamline the function, relying on the default case to handle undefined
status
.Also applies to: 28-29
1-2
: Avoid unnecessary import by replacingisDefined
checkImporting
isDefined
fromclass-validator
adds an extra dependency for a simple check. You can replace it with a direct comparison toundefined
.Apply this diff to remove the import and adjust the code:
-import { isDefined } from 'class-validator' ... - if (!isDefined(status)) return 'blue' + if (status === undefined) return 'blue'This reduces dependencies and might improve tree-shaking and bundling.
Alternatively, as mentioned in the previous comment, consider removing this check entirely if it's redundant.
Also applies to: 9-9
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (13)
libs/api/domains/health-directorate/src/lib/health-directorate.resolver.ts
(1 hunks)libs/api/domains/health-directorate/src/lib/health-directorate.service.ts
(2 hunks)libs/api/domains/health-directorate/src/lib/models/enums.ts
(1 hunks)libs/api/domains/health-directorate/src/lib/models/vaccinations.model.ts
(2 hunks)libs/api/domains/health-directorate/src/lib/utils/mappers.ts
(1 hunks)libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json
(3 hunks)libs/clients/health-directorate/src/lib/clients/vaccinations/vaccinations.service.ts
(3 hunks)libs/service-portal/health/src/screens/Vaccinations/Vaccinations.graphql
(1 hunks)libs/service-portal/health/src/screens/Vaccinations/VaccinationsWrapper.tsx
(1 hunks)libs/service-portal/health/src/screens/Vaccinations/dataStructure.ts
(0 hunks)libs/service-portal/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx
(3 hunks)libs/service-portal/health/src/screens/Vaccinations/tables/VaccinationsTable.tsx
(0 hunks)libs/service-portal/health/src/utils/tagSelector.ts
(1 hunks)
💤 Files with no reviewable changes (2)
- libs/service-portal/health/src/screens/Vaccinations/dataStructure.ts
- libs/service-portal/health/src/screens/Vaccinations/tables/VaccinationsTable.tsx
🧰 Additional context used
📓 Path-based instructions (11)
libs/api/domains/health-directorate/src/lib/health-directorate.resolver.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/health-directorate/src/lib/health-directorate.service.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/health-directorate/src/lib/models/enums.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/health-directorate/src/lib/models/vaccinations.model.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/health-directorate/src/lib/utils/mappers.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/health-directorate/src/lib/clients/vaccinations/vaccinations.service.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/health/src/screens/Vaccinations/Vaccinations.graphql (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/health/src/screens/Vaccinations/VaccinationsWrapper.tsx (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/health/src/utils/tagSelector.ts (1)
Pattern libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🪛 eslint
libs/service-portal/health/src/screens/Vaccinations/Vaccinations.graphql
[error] 1-1: Parsing error: Unexpected token getVaccinations
🔇 Additional comments (17)
libs/service-portal/health/src/screens/Vaccinations/Vaccinations.graphql (1)
1-2
: LGTM! Clean implementation of locale support.
The addition of the optional locale parameter and its integration with healthDirectorateVaccinations is well-structured and maintains backward compatibility.
🧰 Tools
🪛 eslint
[error] 1-1: Parsing error: Unexpected token getVaccinations
libs/api/domains/health-directorate/src/lib/models/enums.ts (1)
1-15
: LGTM on technical implementation
The implementation follows TypeScript best practices:
- Proper use of string enum
- Correct export for reusability
- Proper GraphQL registration
libs/api/domains/health-directorate/src/lib/utils/mappers.ts (2)
1-2
: LGTM! Imports are well-structured
The imports are properly typed and follow best practices for tree-shaking by importing specific enum types.
4-27
: LGTM! Well-structured mapping function
The implementation is type-safe, handles all cases comprehensively, and provides a sensible default fallback.
libs/api/domains/health-directorate/src/lib/models/vaccinations.model.ts (1)
1-1
: Verify the necessity of maintaining two vaccination status enums.
The code imports both DiseaseVaccinationDtoVaccinationStatusEnum
and VaccinationStatusEnum
. Consider if both are necessary or if we can consolidate them to avoid confusion.
Let's check the relationship between these enums:
Also applies to: 3-3
libs/clients/health-directorate/src/lib/clients/vaccinations/vaccinations.service.ts (2)
6-6
: LGTM: Import follows TypeScript guidelines
The addition of the locale enum import enhances type safety for the new locale-based functionality.
44-52
: 🛠️ Refactor suggestion
Enhance locale parameter handling and validation
While the implementation works, consider these improvements for better robustness:
public async getVaccinationDiseaseDetail(
auth: Auth,
- locale: string,
+ locale: 'is' | 'en',
): Promise<Array<DiseaseVaccinationDto> | null> {
+ const supportedLocales = {
+ is: MeVaccinationControllerGetVaccinationsForDiseasesLocaleEnum.Is,
+ en: MeVaccinationControllerGetVaccinationsForDiseasesLocaleEnum.En,
+ };
+
+ if (!supportedLocales[locale]) {
+ throw new Error(`Unsupported locale: ${locale}. Supported locales: ${Object.keys(supportedLocales)}`);
+ }
+
const disease = await this.vaccinationsApiWithAuth(auth)
.meVaccinationControllerGetVaccinationsForDiseases({
- locale:
- locale === 'is'
- ? MeVaccinationControllerGetVaccinationsForDiseasesLocaleEnum.Is
- : MeVaccinationControllerGetVaccinationsForDiseasesLocaleEnum.En,
+ locale: supportedLocales[locale],
})
This refactor:
- Adds type safety with a union type for locale
- Validates supported locales explicitly
- Makes the code more maintainable if new locales are added
- Improves error messaging
libs/api/domains/health-directorate/src/lib/health-directorate.resolver.ts (1)
75-80
: LGTM! Consistent locale handling implementation.
The implementation follows the established patterns in the resolver, with proper TypeScript types and GraphQL schema configuration. The default locale 'is' matches the convention used in other methods.
Let's verify the consistency of locale handling across the codebase:
✅ Verification successful
Locale handling is consistent and properly implemented
The verification shows that:
- The default locale 'is' is consistently used across multiple methods in the resolver
- The
getVaccinations
implementation follows the same pattern as other locale-aware methods - The service layer is properly integrated with the locale parameter
- The implementation maintains consistency with other resolvers in the codebase that handle localization
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify consistent locale handling in GraphQL resolvers
# Expected: All resolver methods handling locale should follow similar pattern
# Search for GraphQL Query/Mutation methods with locale parameter
ast-grep --pattern 'class $_ {
$$$
@Query($_)
$_($$$@Args("locale"$$$)$$$) {
$$$
}
}'
# Search for GraphQL Mutation methods with locale parameter
ast-grep --pattern 'class $_ {
$$$
@Mutation($_)
$_($$$@Args("locale"$$$)$$$) {
$$$
}
}'
Length of output: 202
Script:
#!/bin/bash
# Let's try a different approach to verify locale handling
# Search for methods with locale parameter in resolver files
rg -U "@(Query|Mutation).*\n.*locale.*\n.*\{" --type ts
# Find all resolver files that might handle locale
fd resolver.ts$ --type f --exec grep -l "locale.*=.*'is'" {} \;
# Search specifically for getVaccinations method implementations
ast-grep --pattern 'getVaccinations($_) {
$$$
}'
Length of output: 752
Script:
#!/bin/bash
# Let's examine the locale handling in health-directorate.resolver.ts more closely
# Show the content of health-directorate.resolver.ts with context
rg -A 2 -B 2 "@(Query|Mutation).*locale.*" ./libs/api/domains/health-directorate/src/lib/health-directorate.resolver.ts
# Look for other methods in the same file that might handle locale
rg "locale.*=.*'is'" ./libs/api/domains/health-directorate/src/lib/health-directorate.resolver.ts
# Check the API interface/service for locale handling
rg -A 1 "getVaccinations" ./libs/api/domains/health-directorate/src/lib/
Length of output: 1021
libs/service-portal/health/src/screens/Vaccinations/VaccinationsWrapper.tsx (1)
18-23
: LGTM: Proper locale implementation
The locale handling is implemented correctly using the useLocale
hook and properly passed to the GraphQL query.
libs/service-portal/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx (1)
Line range hint 1-106
: LGTM for reusability and tree-shaking practices!
The component follows good practices:
- Uses TypeScript for type safety
- Properly imports from shared libraries
- Follows tree-shakeable import patterns
- Is reusable across different NextJS apps through the service-portal library
libs/api/domains/health-directorate/src/lib/health-directorate.service.ts (3)
13-14
: LGTM: Clean import declarations
The imports are properly typed and specific, following good tree-shaking practices.
76-79
: LGTM: Well-typed method signature
The method signature properly incorporates locale support with appropriate TypeScript types, maintaining consistency with other methods in the service.
95-95
: Verify vaccination status mapping implementation
The code now uses a dedicated mapping function for vaccination status, which is good for maintainability. However, we should verify the implementation of this mapping function.
✅ Verification successful
Let me gather more information about the enum types used in the mapping function.
Let me search for the DTO enum definition using a different pattern.
Vaccination status mapping implementation is correct and comprehensive
The mapping function correctly handles all possible vaccination status values from the health directorate DTO to the internal enum. The implementation:
- Maps all status variants: valid, complete, expired, incomplete, rejected, undetermined, undocumented, and unvaccinated
- Provides a safe fallback to 'undetermined' for unknown values
- Maintains consistent status values between the source and target enums
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for the mapping function implementation and its test coverage
echo "Searching for mapping function implementation:"
rg -A 10 "export const mapVaccinationStatus"
echo "\nSearching for related test files:"
fd "mappers.test" --exec rg -l "mapVaccinationStatus"
Length of output: 1470
Script:
#!/bin/bash
# Search for the enum definitions
echo "Searching for VaccinationStatusEnum definition:"
rg -A 10 "enum VaccinationStatusEnum"
echo "\nSearching for DiseaseVaccinationDtoVaccinationStatusEnum definition:"
rg -A 10 "enum DiseaseVaccinationDtoVaccinationStatusEnum"
# Search for test coverage
echo "\nSearching for test files with broader pattern:"
fd test --exec rg -l "mapVaccinationStatus|VaccinationStatusEnum"
Length of output: 1561
Script:
#!/bin/bash
# Search for the DTO enum in generated files
echo "Searching for DiseaseVaccinationDto definition:"
rg -A 15 "DiseaseVaccinationDto" --type ts
# Search for any test files in the health-directorate domain
echo "\nSearching for test files in health-directorate domain:"
fd test.ts$ -p libs/api/domains/health-directorate --exec rg -l "vaccination"
Length of output: 9259
libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json (3)
61-68
: LGTM: Well-structured locale parameter definition.
The locale parameter is correctly defined with:
- Optional status (required: false)
- Proper enum values ["en", "is"]
- Clear query parameter placement
130-135
: Maintain consistency with the previous locale parameter definition.
The implementation matches the previous endpoint's locale parameter, ensuring a consistent API design.
893-896
: Schema update aligns with API evolution best practices.
The addition of the vaccines
array to UpdateDiseaseDto
maintains proper type references and follows OpenAPI standards.
Let's verify the schema usage:
✅ Verification successful
Schema update maintains proper OpenAPI structure and type references
The verification confirms that:
- The
VaccineDiseaseDto
schema is properly defined in the OpenAPI specification - The schema is correctly referenced in both
DiseaseDto
andUpdateDiseaseDto
- The
vaccines
array property follows OpenAPI 3.0 standards with proper type definitions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for UpdateDiseaseDto usage to ensure compatibility
rg -l "UpdateDiseaseDto" --type ts
Length of output: 34
Script:
#!/bin/bash
# Let's first check the actual schema definition in the JSON file
cat libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json
# Also search for any references to VaccineDiseaseDto
rg "VaccineDiseaseDto" --type ts --type json -A 3
Length of output: 30754
libs/service-portal/health/src/utils/tagSelector.ts (1)
6-8
: Good use of TypeScript for function signature
The function tagSelector
correctly uses TypeScript to define the parameter and return types, enhancing type safety.
* fix: tags * feat: add locale to service WIP * feat: add locale from service * feat: add locale to query call
* fix: tags * feat: add locale to service WIP * feat: add locale from service * feat: add locale to query call
* fix(my-pages): health vaccination tags & locale (#16567) * fix: tags * feat: add locale to service WIP * feat: add locale from service * feat: add locale to query call * fix(api): add ff to resolver (#16865) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(api): add correct scope (#16874) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
My pages - Health - Vaccination fixes
What
Fix colors for vaccination status tags
Add locale to get vaccination query
Summary by CodeRabbit
Release Notes
New Features
locale
parameter in various API endpoints and methods.Bug Fixes
Refactor
Chores