Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(my-pages): my pages & app fix for health #16873

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

disaerna
Copy link
Member

@disaerna disaerna commented Nov 14, 2024

Hotfix 🔥

What

#16874
#16567
#16865

Why

Fix health related data for vaccinations and organ donation

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

disaerna and others added 2 commits November 14, 2024 13:08
* fix: tags

* feat: add locale to service WIP

* feat: add locale from service

* feat: add locale to query call
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@disaerna disaerna requested review from a team as code owners November 14, 2024 15:02
Copy link
Contributor

coderabbitai bot commented Nov 14, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@disaerna disaerna changed the title Hotfix/health tags n stuff hotfix(my-pages): my pages & app fix for health Nov 14, 2024
thorkellmani
thorkellmani previously approved these changes Nov 14, 2024
Copy link
Member

@thorkellmani thorkellmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disaerna disaerna changed the title hotfix(my-pages): my pages & app fix for health fix(my-pages): my pages & app fix for health Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.51%. Comparing base (ae92d08) to head (4a29afd).
Report is 3 commits behind head on release/32.3.0.

Files with missing lines Patch % Lines
...c/lib/clients/vaccinations/vaccinations.service.ts 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/32.3.0   #16873      +/-   ##
==================================================
- Coverage           36.51%   36.51%   -0.01%     
==================================================
  Files                6890     6890              
  Lines              143806   143810       +4     
  Branches            40971    40973       +2     
==================================================
+ Hits                52513    52514       +1     
- Misses              91293    91296       +3     
Flag Coverage Δ
air-discount-scheme-backend 54.07% <100.00%> (+0.02%) ⬆️
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-domains-air-discount-scheme 37.05% <100.00%> (+0.06%) ⬆️
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.82% <100.00%> (+0.01%) ⬆️
api-domains-criminal-record 47.52% <100.00%> (+0.07%) ⬆️
api-domains-driving-license 44.49% <100.00%> (+0.03%) ⬆️
api-domains-education 31.30% <100.00%> (+0.06%) ⬆️
api-domains-health-insurance 34.38% <100.00%> (+0.09%) ⬆️
api-domains-mortgage-certificate 34.71% <100.00%> (+0.05%) ⬆️
api-domains-payment-schedule 41.28% <100.00%> (+0.05%) ⬆️
application-api-files 56.60% <100.00%> (+0.05%) ⬆️
application-core 71.23% <ø> (-0.41%) ⬇️
application-system-api 41.12% <28.57%> (+0.01%) ⬆️
application-template-api-modules 27.70% <100.00%> (+0.01%) ⬆️
application-templates-accident-notification 29.21% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.26% <ø> (ø)
application-templates-driving-license 18.40% <ø> (ø)
application-templates-estate 12.18% <ø> (ø)
application-templates-example-payment 25.17% <ø> (ø)
application-templates-financial-aid 15.56% <ø> (ø)
application-templates-general-petition 23.40% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.20% <ø> (ø)
application-templates-mortgage-certificate 43.55% <ø> (ø)
application-templates-parental-leave 29.96% <ø> (ø)
application-types 6.60% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.86% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.24% <100.00%> (+0.08%) ⬆️
clients-driving-license-book 43.47% <100.00%> (+0.05%) ⬆️
clients-financial-statements-inao 49.02% <100.00%> (+0.07%) ⬆️
clients-license-client 1.83% <ø> (ø)
clients-regulations 42.31% <100.00%> (+0.08%) ⬆️
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.21% <100.00%> (+0.04%) ⬆️
cms 0.42% <ø> (ø)
cms-translations 38.95% <100.00%> (+0.01%) ⬆️
dokobit-signing 62.67% <100.00%> (+0.17%) ⬆️
download-service 44.27% <100.00%> (+0.03%) ⬆️
email-service 60.49% <100.00%> (+0.16%) ⬆️
feature-flags 90.55% <100.00%> (+0.15%) ⬆️
file-storage 52.77% <100.00%> (+0.23%) ⬆️
financial-aid-backend 51.28% <100.00%> (+0.02%) ⬆️
judicial-system-api 19.57% <ø> (ø)
judicial-system-audit-trail 68.78% <100.00%> (+0.16%) ⬆️
judicial-system-backend 55.21% <100.00%> (+<0.01%) ⬆️
judicial-system-message 66.86% <100.00%> (+0.13%) ⬆️
judicial-system-message-handler 47.81% <100.00%> (+0.18%) ⬆️
judicial-system-scheduler 70.42% <100.00%> (+0.04%) ⬆️
license-api 42.64% <100.00%> (+0.09%) ⬆️
nest-config 77.94% <100.00%> (+0.13%) ⬆️
nest-feature-flags 51.02% <100.00%> (+0.12%) ⬆️
nova-sms 62.00% <100.00%> (+0.19%) ⬆️
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 15.96% <ø> (ø)
services-auth-admin-api 51.88% <100.00%> (+<0.01%) ⬆️
services-auth-delegation-api 57.47% <100.00%> (+<0.01%) ⬆️
services-auth-ids-api 51.46% <100.00%> (-0.01%) ⬇️
services-auth-personal-representative 45.10% <100.00%> (+0.01%) ⬆️
services-auth-personal-representative-public 41.25% <100.00%> (-0.03%) ⬇️
services-auth-public-api 48.97% <100.00%> (+0.01%) ⬆️
services-endorsements-api 53.62% <100.00%> (+0.02%) ⬆️
services-sessions 65.36% <100.00%> (+0.03%) ⬆️
services-university-gateway 49.24% <100.00%> (-0.06%) ⬇️
services-user-notification 46.90% <100.00%> (+<0.01%) ⬆️
services-user-profile 61.85% <100.00%> (+0.01%) ⬆️
web 1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/feature-flags/src/lib/features.ts 100.00% <100.00%> (ø)
...c/lib/clients/vaccinations/vaccinations.service.ts 32.00% <0.00%> (-2.79%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabd84e...4a29afd. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Nov 14, 2024

Datadog Report

All test runs ae5327e 🔗

70 Total Test Services: 0 Failed, 67 Passed
🔻 Test Sessions change in coverage: 24 decreased, 22 increased, 154 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 82 0 32.6s N/A Link
air-discount-scheme-web 0 0 0 2 0 9.59s N/A Link
api 0 0 0 4 0 3.22s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 21.47s N/A Link
api-domains-assets 0 0 0 3 0 13.57s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 15.07s N/A Link
api-domains-communications 0 0 0 5 0 35.46s N/A Link
api-domains-criminal-record 0 0 0 5 0 10.99s 1 decreased (-0.04%) Link
api-domains-driving-license 0 0 0 23 0 35.09s N/A Link
api-domains-education 0 0 0 8 0 23.61s 1 increased (+0.39%) Link

🔻 Code Coverage Decreases vs Default Branch (24)

This report shows up to 5 code coverage decreases.

  • services-auth-delegation-api - jest 51.37% (-0.37%) - Details
  • services-auth-public-api - jest 45.99% (-0.32%) - Details
  • services-auth-admin-api - jest 47.58% (-0.32%) - Details
  • services-auth-personal-representative-public - jest 40.74% (-0.31%) - Details
  • services-auth-personal-representative - jest 43.99% (-0.29%) - Details

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Copy link
Member

@thorkellmani thorkellmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again)

Copy link
Member

@baering baering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core file LGTM

@disaerna disaerna added the automerge Merge this PR as soon as all checks pass label Nov 15, 2024
@kodiakhq kodiakhq bot merged commit 3b4a5a6 into release/32.3.0 Nov 15, 2024
202 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/health-tags-n-stuff branch November 15, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants