Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cms): Latest Generic List Items - Mark seeMorePage field as nullable #15997

Merged

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Sep 13, 2024

Latest Generic List Items - Mark seeMorePage field as nullable

What

I forgot to mark the field as nullable so now the field is required in the CMS (when it really shouldn't be)

Summary by CodeRabbit

  • New Features
    • Enhanced the seeMorePage property to allow explicit null values, improving flexibility in data handling.

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Sep 13, 2024
@RunarVestmann RunarVestmann requested review from a team as code owners September 13, 2024 11:30
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes involve an update to the LatestGenericListItems class in the latestGenericListItems.model.ts file. The seeMorePage property has been modified to include an additional option, { nullable: true }, within its @CacheField decorator. This update explicitly allows the seeMorePage property to accept null values, clarifying its nullability in the data model.

Changes

File Path Change Summary
libs/cms/src/lib/models/latestGenericListItems.model.ts Modified seeMorePage property to include { nullable: true } option in @CacheField decorator.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (2c7c9c0) to head (9a57692).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cms/src/lib/models/latestGenericListItems.model.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15997      +/-   ##
==========================================
- Coverage   36.85%   36.84%   -0.01%     
==========================================
  Files        6718     6718              
  Lines      137728   137728              
  Branches    39156    39156              
==========================================
- Hits        50753    50750       -3     
- Misses      86975    86978       +3     
Flag Coverage Δ
api 3.39% <ø> (ø)
api-domains-auth-admin 49.89% <ø> (ø)
api-domains-communications 40.42% <0.00%> (ø)
application-system-api 41.67% <0.00%> (ø)
application-template-api-modules 23.46% <ø> (-0.01%) ⬇️
cms-translations 39.57% <0.00%> (ø)
judicial-system-api 19.35% <ø> (ø)
judicial-system-backend 55.72% <0.00%> (ø)
services-auth-ids-api 54.00% <ø> (-0.05%) ⬇️
services-user-notification 47.61% <0.00%> (ø)
services-user-profile 62.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cms/src/lib/models/latestGenericListItems.model.ts 42.85% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7c9c0...9a57692. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 13, 2024

Datadog Report

All test runs 895648c 🔗

12 Total Test Services: 0 Failed, 11 Passed
➡️ Test Sessions change in coverage: 30 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.89s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 13.23s 1 no change Link
api-domains-communications 0 0 0 5 0 32.22s 1 no change Link
api-domains-license-service 0 0 0 0 0 510.65ms 1 no change Link
application-system-api 0 0 0 111 2 3m 11.52s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 43.06s 1 no change Link
cms-translations 0 0 0 3 0 25.63s 1 no change Link
judicial-system-api 0 0 0 57 0 6.82s 1 no change Link
judicial-system-backend 0 0 0 20897 0 20m 31.99s 1 no change Link
services-auth-ids-api 0 0 0 145 0 1m 12.56s 1 no change Link

@kodiakhq kodiakhq bot merged commit 3b8183d into main Sep 13, 2024
57 checks passed
@kodiakhq kodiakhq bot deleted the fix/cms-latest-generic-list-items-see-more-page-nullable branch September 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants