feat(web): Latest Generic List Items content type - Don't allow clicking on cards if there isn't a 'see more page'

[RunarVestmann]

Latest Generic List Items content type - Don't allow clicking on cards if there isn't a 'see more page'

Why

• Otherwise in most cases the user would click and reach a 404 page (which isn't helpful)

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced item clickability logic in the list, ensuring items are only clickable when all necessary conditions are met (item type, link text, and href are defined).

[coderabbitai]

Walkthrough

The changes in the LatestGenericListItems.tsx file enhance the logic for determining the clickability of list items. The new implementation requires that an item must have its itemType set to 'Clickable' and both slice.seeMoreLinkText and seeMoreLinkHref defined to be considered clickable. This adjustment ensures that items are only marked as clickable when all necessary conditions are met.

Changes

File	Change Summary
apps/web/components/GenericList/LatestGenericListItems/LatestGenericListItems.tsx	Modified clickability logic to require itemType to be 'Clickable' and both seeMoreLinkText and seeMoreLinkHref to be defined.

Possibly related PRs

• fix(cms): Latest Generic List Items - Mark seeMorePage field as nullable #15997: The changes in this PR involve the seeMorePage property, which is relevant to the clickability logic in the main PR since it checks for the presence of seeMoreLinkHref and seeMoreLinkText. Making seeMorePage nullable enhances the flexibility of handling cases where links may not be available, aligning with the main PR's focus on ensuring items are only clickable when all necessary conditions are met.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for generating code suggestions in code reviews.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.77%. Comparing base (ebbb347) to head (3f92d6f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../LatestGenericListItems/LatestGenericListItems.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16031      +/-   ##
==========================================
- Coverage   36.77%   36.77%   -0.01%     
==========================================
  Files        6733     6733              
  Lines      138117   138119       +2     
  Branches    39246    39249       +3     
==========================================
  Hits        50788    50788              
- Misses      87329    87331       +2     

Flag	Coverage Δ
judicial-system-api	19.40% <ø> (ø)
judicial-system-backend	55.21% <ø> (ø)
judicial-system-formatters	79.69% <ø> (ø)
judicial-system-message	66.86% <ø> (ø)
judicial-system-message-handler	47.71% <ø> (ø)
judicial-system-scheduler	69.06% <ø> (ø)
judicial-system-types	48.35% <ø> (ø)
judicial-system-web	28.71% <ø> (ø)
web	1.85% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../LatestGenericListItems/LatestGenericListItems.tsx	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbb347...3f92d6f. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: fix/web-latest-generic-list-items-non-clickable
Commit report: 93fdedc
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 30.89s Total Time
➡️ Test Sessions change in coverage: 1 no change