fix(search-indexer): Limit what fields are indexed for "Latest Generic List Items" model

[RunarVestmann]

Limit what fields are indexed for "Latest Generic List Items" model

What

Only keep required fields since optional reference fields can lead to a circular reference

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Improved mapping logic for the seeMorePage object, enhancing clarity and performance.
• Bug Fixes
  • Implemented optional chaining to prevent runtime errors when accessing nested fields.

[coderabbitai]

Walkthrough

The changes focus on the mapSeeMorePage function in the latestGenericListItems.model.ts file. The code has been updated to improve how fields are accessed from the seeMorePage object, utilizing optional chaining to avoid runtime errors. Specific properties are now directly assigned from seeMorePage.fields, replacing the previous use of spread operators. This results in a clearer mapping of only the necessary fields.

Changes

File Path	Change Summary
libs/cms/src/lib/models/latestGenericListItems.model.ts	Restructured mapSeeMorePage function to use optional chaining and direct assignments for specific fields from seeMorePage. Removed spread operator usage.

Possibly related PRs

• fix(cms): Latest Generic List Items - Mark seeMorePage field as nullable #15997: This PR modifies the seeMorePage property in the same latestGenericListItems.model.ts file, which is directly related to the changes made in the mapSeeMorePage function regarding how fields are accessed and handled.

Suggested reviewers

• siggifv

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.70%. Comparing base (9ca1522) to head (ca2556c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...cms/src/lib/models/latestGenericListItems.model.ts	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16187      +/-   ##
==========================================
- Coverage   36.70%   36.70%   -0.01%     
==========================================
  Files        6776     6776              
  Lines      139602   139605       +3     
  Branches    39687    39693       +6     
==========================================
- Hits        51242    51237       -5     
- Misses      88360    88368       +8     

Flag	Coverage Δ
api	3.39% <ø> (ø)
api-domains-auth-admin	48.77% <ø> (ø)
api-domains-communications	39.96% <0.00%> (-0.04%)	⬇️
application-system-api	41.62% <0.00%> (-0.01%)	⬇️
application-template-api-modules	23.72% <ø> (+0.01%)	⬆️
application-ui-shell	21.29% <ø> (ø)
cms	0.43% <0.00%> (-0.01%)	⬇️
cms-translations	39.08% <0.00%> (-0.04%)	⬇️
judicial-system-api	18.46% <ø> (ø)
judicial-system-backend	54.82% <0.00%> (-0.03%)	⬇️
services-user-notification	47.13% <0.00%> (-0.03%)	⬇️
web	1.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...cms/src/lib/models/latestGenericListItems.model.ts	35.71% <0.00%> (-7.15%)	⬇️

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca1522...ca2556c. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 04fa6a8 🔗

✅ 10 Total Test Services: 0 Failed, 9 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.02%), 25 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.99s	1 no change	Link
api-domains-auth-admin	0	0	0	18	0	13.94s	1 no change	Link
api-domains-communications	0	0	0	5	0	31.86s	1 no change	Link
api-domains-license-service	0	0	0	0	0	571.24ms	1 no change	Link
application-system-api	0	0	0	111	2	3m 22.58s	1 no change	Link
application-template-api-modules	0	0	0	109	0	1m 42.29s	1 no change	Link
cms-translations	0	0	0	3	0	27.42s	1 no change	Link
judicial-system-api	0	0	0	57	0	6.57s	1 no change	Link
judicial-system-backend	0	0	0	20886	0	18m 24.68s	1 decreased (-0.02%)	Link
services-user-notification	0	0	0	51	0	1m 31.6s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

• judicial-system-backend - jest 58.2% (-0.02%) - Details