WIP: update go-libp2p to v0.16.0 #8522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
update-libp2p
branch
5 times, most recently
from
cfe9509
to
65f6bfa
Compare
marten-seemann
force-pushed
the
update-libp2p
branch
from
65f6bfa
to
1026be3
Compare
vyzo
reviewed
Oct 21, 2021
|
|
||
| #### `Swarm.RelayServiceOpts.MaxReservationsPerPeer` | ||
|
|
||
| Maximum number of reservations originating from the same peer. |
There was a problem hiding this comment.
we might want to explain how this is refreshed.
lidel
reviewed
Oct 26, 2021
There was a problem hiding this comment.
Refactored config and docs in this PR to follow go-ipfs-config changes from ipfs/go-ipfs-config#146.
lidel
requested changes
Oct 26, 2021
|
don't we also want to optionally enable hole punching, at least when autorelay is enabled? |
We probably want to get libp2p/go-libp2p#1214 merged. I'm not sure this is realistic before we the IPFS release is cut. |
|
Circleci is working again so I've re-run yesterday's jobs. The GO-JS interop tests fail due to Do we need to refactor tests so both ends to speak v2, |
This comment has been minimized.
This comment has been minimized.
lidel
added a commit
that referenced
this pull request
Oct 28, 2021
Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
reviewed
Oct 28, 2021
|
|
||
| Time limit before a relayed connection is reset. | ||
|
|
||
| Default: `"2m"` |
There was a problem hiding this comment.
💭 those "defaults" come from libp2p. Should we hardcode them in go-ipfs using WithDefaults?
Right now this PR uses 0 as placeholder and the actual default value that is delegated to go-ipfs, so if go-libp2p changes the defaults, docs will get out of date.
lidel
added a commit
to ipfs/go-ipfs-config
that referenced
this pull request
Oct 28, 2021
needed for sharness tests in ipfs/kubo#8522
lidel
added a commit
to ipfs/go-ipfs-config
that referenced
this pull request
Oct 28, 2021
adds Internal.Libp2pForceReachability needed for sharness tests in ipfs/kubo#8522 Co-authored-by: Marcin Rataj <[email protected]>
lidel
reviewed
Oct 28, 2021
There was a problem hiding this comment.
Some config updates:
- switched to the latest version of feat: Swarm.RelayService (circuit v2) go-ipfs-config#146 and updated docs to reflect recent changes
Internal.Libp2pForceReachability(OptionalString) should be available now, feel free to wire it up somewhere withforceReachability := cfg.Internal.Libp2pForceReachability.WithDefault("")
marten-seemann
pushed a commit
that referenced
this pull request
Oct 30, 2021
Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <[email protected]>
marten-seemann
force-pushed
the
update-libp2p
branch
from
b05c673
to
1741a58
Compare
marten-seemann
force-pushed
the
update-libp2p
branch
from
c0c40eb
to
9e27b76
Compare
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
marten-seemann
force-pushed
the
update-libp2p
branch
from
9e27b76
to
4142b46
Compare
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
marten-seemann
force-pushed
the
update-libp2p
branch
from
3da98d5
to
fde7d01
Compare
marten-seemann
force-pushed
the
update-libp2p
branch
from
fde7d01
to
b526b28
Compare
4 tasks
This was referenced Nov 19, 2021
…8559) * exit when Swarm.EnableRelayHop is set * chore: go-ipfs-config v0.18.0 Co-authored-by: Marcin Rataj <[email protected]>
|
Continued in #8563 |
lidel
added a commit
to ipfs/interop
that referenced
this pull request
Nov 29, 2021
Needed for: ipfs/kubo#8522
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft, as it references a commit on master (go-libp2p v0.16.0 is not yet released).