Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go-libp2p 0.16 and autosharding and go-datastore to take contexts #8563

Merged
merged 46 commits into from
Nov 29, 2021

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Nov 22, 2021

This PR ties together #8522 and #8527 since they both rely on updates to go-datastore and therefore need to be merged together.

Interop tests: ipfs/interop#400

marten-seemann and others added 30 commits November 12, 2021 21:27
making deprecation notice match the go-ipfs-config key
Clarified docs based on
#8522 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
this moves relay "user" flag before the "service" to align better with
new docs in effort to limit the number of people that mistake the two.

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
This switches to config that supports setting and reading
Internal.Libp2pForceReachability OptionalString flag

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
does not cause issue locally, let's see how behaves on CI
This is for testing the libp2p release, since the context changes are
not plumbed all the way through.
- applies fix from go-ipfs-config which removes null when default
- escapes JSON string when passed in sharness script
* test: add tests for automatic sharding and unsharding
* refactor: changed some naming in the sharding sharness tests to make more sense

Co-authored-by: Adin Schmahmann <[email protected]>
This is for testing the libp2p release, since the context changes are
not plumbed all the way through.
@aschmahmann aschmahmann changed the title Feat/update datastore update go-datastore to take contexts Nov 22, 2021
@lidel lidel changed the title update go-datastore to take contexts feat: go-libp2p 0.16 and autosharding and go-datastore to take contexts Nov 23, 2021
This ensures existing users of global sharding experiment get notified
that the flag no longer works + that autosharding happens automatically.

For people who NEED to keep the old behavior (eg. have no time to
migrate today) there is a note about restoring it with
`UnixFSShardingSizeThreshold`.
.circleci/main.yml Outdated Show resolved Hide resolved
github.com/ipfs/go-fs-lock v0.0.7
github.com/ipfs/go-graphsync v0.8.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: use released go-graphsync

Co-authored-by: Marcin Rataj <[email protected]>
@aschmahmann aschmahmann marked this pull request as ready for review November 29, 2021 18:25
@aschmahmann
Copy link
Contributor Author

We're going to squash the history here since it's reasonably long and pretty messy.

@aschmahmann aschmahmann enabled auto-merge (squash) November 29, 2021 18:56
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👀 💧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants