-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
27beb3b
to
9fece46
Compare
Q: JS side of things does not seem to support v2 protocol(?) Q: do we need to diable mdns, bootstrappers and routing to be sure this works?
9fece46
to
6d00cc7
Compare
Most likely those cases fail because JS is unaware of reservation token logic present in circuit v2 (or something else). Need to be revisited after we have v2 in JS.
Refactored GO side of things to leverage circuit v2 and ensure correct relay is used by setting Unfortunately JS side of things (js-ipfs running in nodejs or in browser) does not talk circuit v2 and some combinations fail to pass. Landing this in time for go-ipfs 0.11 is unlikely and I think we need to For future reference, combinations which currently do not pass:
If I read this correctly, JS-IPFS cant use GO-IPFS relays v2 (fails in both node and browser scenarios), and needs to use v1 from js-ipfs until support for v2 is added to JS. |
Sidenote:
|
There are 2 reasons why a test might fail here:
We probably should have another set of tests using relayd as a relay, configured as a v1 relay. With that configuration, all tests that we currently have should pass. |
- go-ipfs 0.11+ can only act as relay v2 - js-ipfs remains v1 for now - we can run relayd as reference implementation of v1 or v2, giving us additional check - relayd can't be run in browser as it does not have ipfsd-ctl/aegir tooling go-ipfs and js-ipfs have
We want to see what works and what not
I've split circuit tests into v1 and v2 sections. v1 tests Tests of circuit v1 and v2 work, there is an unrelated failure in @achingbrain mind eyeballing this PR? Note:
|
latest execa is pure ESM and Electron does not speak that :|
CI was failing due to sharding changes, we continue this in #400 (CI is finally green there) |
This PR aims to fix the interop tests in ipfs/kubo#8522 and close #396
test/utils/circuit.js
to use new go-ipfs-config keysnode bin/ipfs-interop.js -- -t node --grep "circuit"
pass