Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename --ts flag to --ts-repo and fix ts repo support #730

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

hugomrdias
Copy link
Member

  • we need to rename the flag to avoid conflicts in the options object with the ts cmd
  • generate js files in TS repos

- we need to rename the flag to avoid conflicts in the options object with the `ts` cmd
- generate js files in TS repos
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugomrdias hugomrdias merged commit 3d54004 into master Jan 27, 2021
@hugomrdias hugomrdias deleted the feat/ts-repo-support branch January 27, 2021 10:17
@mpetrunic
Copy link
Contributor

@hugomrdias when will this be released?

@hugomrdias
Copy link
Member Author

Maybe tomorrow there's some other changes I want to get in

@mpetrunic
Copy link
Contributor

Also I noticed this when running your PR on noise with node12:
#739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants