Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aegir not working with node 12 #739

Closed
mpetrunic opened this issue Feb 10, 2021 · 1 comment
Closed

Aegir not working with node 12 #739

mpetrunic opened this issue Feb 10, 2021 · 1 comment

Comments

@mpetrunic
Copy link
Contributor

mpetrunic commented Feb 10, 2021

Describe the bug

Seems like aegir is using syntax not supported on node12.

To Reproduce

Run this PR with node12: ChainSafe/js-libp2p-noise#89

https://github.com/NodeFactoryIo/js-libp2p-noise/pull/89/checks?check_run_id=1871241958

Expected behavior

Either support node 12 or if there is no plan for that, we will remove node12 ci matrix

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS] Ubuntu
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@hugomrdias
Copy link
Member

its already fixed in master, thank you for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants