fix: fix repo to use new aegir #89
Conversation
- tweak tsconfig.js - add ts type check including test files - fix ci setup for new aegir - add new awesome aegir docs feature - you can publish to github pages with the flag --publish
There was a problem hiding this comment.
LGTM! Thanks @hugomrdias
@mpetrunic the CI job seems stalled. Can you restart it to check if everything is working?
We ran out of free minutes on travis. We are actually paying and using github actions. I think it's just one time thing that we used our free minutes on travis since we had some fork running it's actions there. Do we wait 4 more days to reset? 😄 |
We are also moving to github actions. So perhaps we can just change that here? |
not sure If I can push to this branch but I'll change ci right now |
It helped :) I've added dependency caching to make thing a bit faster. Disabled bundle size checker since we still depend on bcrypto and node-forge which brings bundlesize to ~200kb. I think idea was to move crypto we need to libp2p-crypto but afaik it's not done yet |
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=========================================
Coverage ? 89.90%
=========================================
Files ? 16
Lines ? 1773
Branches ? 246
=========================================
Hits ? 1594
Misses ? 179
Partials ? 0 Continue to review full report at Codecov.
|
Yes, that is still the plan, but we could not tackle it yet |
…p2p-noise into feat/new-aegir * 'feat/new-aegir' of https://github.com/hugomrdias/js-libp2p-noise: fix package.json typo and bump nvm to 14
|
Some metrics with the new aegir
Size is bigger because licences are inlined instead of in a separate file. |
|
You've added incremental flag to tsconfig? How do you deal with bugs it's causing (not deleting old files etc)? |
|
The cache wasn't letting me pull the latest aegir. I will add it back once before merging. |
|
Actually theres no real need for incremental right now, gonna remove it. |
|
@mpetrunic can you point me to some issues created by --incremental ? |
Most annoying it that it doesn't remove deleted source file from dist/build directory. That said, you are deleting whole dist directory on every build so it doesn't really matter but that also means that we are deleting tsconfig.tsbuildinfo so incremental flagisn't doing anything afaik. |
|
docs preview |
|
@hugomrdias aegir is dropping node12 support? We need to remove it from CI here as well? |
aegir still works in node12 because the github-action needs it but everything else yes https://github.com/ipfs/community/blob/master/CONTRIBUTING_JS.md#supported-versions
|
|
@mpetrunic its finally ready |
/cc @vasco-santos
needs:
ipfs/aegir#730