Follow Protocol Buffers Style Guide and handle ProtocolParameter upgrades #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cording to the protobuf style guide (https://developers.google.com/protocol-buffers/docs/style)
alexsporn
force-pushed
the
feat/snake_case_fields
branch
from
8f58493
to
3da4eaa
Compare
alexsporn
changed the title
This was
linked to
issues
Jul 26, 2022
muXxer
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://developers.google.com/protocol-buffers/docs/style)
ProtocolParametersfrom theNodeConfigurationinto a separate read call and added the current ones to the confirmed milestones stream.ProtocolParametersin favor ofRawProtocolParametersto make us independent of protocol versions