Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename minPoWScore to minPowScore #78

Closed
grtlr opened this issue Jul 15, 2022 · 4 comments · Fixed by #79
Closed

Rename minPoWScore to minPowScore #78

grtlr opened this issue Jul 15, 2022 · 4 comments · Fixed by #79

Comments

@grtlr
Copy link
Contributor

grtlr commented Jul 15, 2022

@muXxer @alexsporn The later is probably the correct camelCase format of the field.

uint32 minPoWScore = 4;

The current version leads to the following generated Rust code in snake case:

self.min_po_w_score
@alexsporn
Copy link
Member

It is called Proof of work (PoW) (see https://en.wikipedia.org/wiki/Proof_of_work)
Can we add a hint to the Rust generator on how to name that?

@alexsporn
Copy link
Member

According to the style guide the field names should be in snake_case
https://developers.google.com/protocol-buffers/docs/style
Let me experiment

@alexsporn
Copy link
Member

I added a Draft PR with this changes. Also note the prefixing of the enum values.

@grtlr
Copy link
Contributor Author

grtlr commented Jul 15, 2022

Great–thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants