bug: proxyInputs errors when called multiple times

[liamdebeasi]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

4.6.0

Stencil Framework Output Target

Angular

Stencil Framework Output Target Version

0.8.2

Current Behavior

When calling proxyInputs multiple times an Cannot redefine property error is thrown in Chromium-based browsers. (Other browsers still throw an error, but the exact error message is slightly different). This is happening due to our usage of Object.defineProperty:

stencil-ds-output-targets/packages/angular-output-target/angular-component-lib/utils.ts

Line 8 in 0c58ea1

Object.defineProperty(Prototype, item, {

These properties are non-configurable by default, so attempting to change them will result in an error: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty

This is not a problem when using the ProxyCmp decorator since proxyInputs will be called at most once. However, calling proxyInputs in ngOnInit will result in the error if that component is used more than once on a page.

---

Ionic Framework needs to call proxyInputs in ngOnInit instead of using the ProxyCmp decorator to work around an ng-packagr/Webpack bug. Using a provider that references the Angular class in addition to two or more decorators causes the compiled component to be re-assigned. This re-assignment breaks treeshaking and causes components to be bundled even if they are not being used in the app.

See ionic-team/ionic-framework#28359 for more information.

Expected Behavior

I expect proxyInputs to be idempotent. Calling it multiple times should not have a different effect than calling it once.

Steps to Reproduce

1. Clone repo.
2. Run npm install.
3. Run npm run start and open application in browser (typically served on port 4200). You can reproduce this on a non-Chromium browser but just be aware that the exact error message may be worded slightly different.
4. Observe that noted error is thrown.

Code Reproduction URL

https://github.com/dtarnawsky/cs-752

Additional Information

No response

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the output targets, please create a new issue and ensure the template is fully filled out.