Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): standalone form components do not error when multiple are used #28423

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 26, 2023

Issue number: resolves #28418


What is the current behavior?

Due to ionic-team/stencil-ds-output-targets#397, calling proxyInputs for the form controls caused an error to be logged in developer applications.

What is the new behavior?

  • Updated to a version of the Angular output targets with a patch for this error
  • I also excluded the utils.ts from all angular-component-lib directories from prettier since it was causing a diff. These changes are autogenerated so we should not be linting them anyways.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.5.3-dev.11698340692.18daff2f

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package labels Oct 26, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review October 27, 2023 13:22
@liamdebeasi liamdebeasi added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 89698b3 Oct 27, 2023
45 checks passed
@liamdebeasi liamdebeasi deleted the FW-5465 branch October 27, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: IonCheckbox Angular standalone - Cannot redefine property 'checked' in component
2 participants