fix(angular): proxyInputs does not error when called multiple times #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
force-pushed
the
angular-configurable
branch
from
b87cbd4 to
f7e86b0
Compare
liamdebeasi
requested review from
rwaskiewicz,
tanner-reits and
brandyscarney
sean-perkins
approved these changes
Oct 26, 2023
rwaskiewicz
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #397
What is the new behavior?
definePropertyis now configurable meaning the properties can be changed. In this case, the actual property implementations do not change, but they are re-written when callingproxyInputsmultiple times.Does this introduce a breaking change?
Other information
Dev build:
0.0.1-dev.11698340434.1c94d384Ionic dev build available here: ionic-team/ionic-framework#28418 (comment) I used this to manually verify that fix worked in Framework's reproduction case.
This PR uses the output target dev build, so we can leverage Ionic's e2e angular suite to help de-risk this fix: ionic-team/ionic-framework#28423