Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(border): border & border-width mixins for rtl #12029

Closed
wants to merge 15 commits into from
Closed

fix(border): border & border-width mixins for rtl #12029

wants to merge 15 commits into from

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Jun 13, 2017 •
edited
Loading

Short description of what this resolves:

Wrong side borders on rtl

Changes proposed in this pull request:

  • add border & border-width mixins

This is the last RTL mixin needed! (as far as I can see)

Ionic Version: 3.x

Closes: #11352

brandyscarney and others added 14 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@AmitMY
fix(border): border & border-width mixins for rtl
0812da9
@AmitMY
fix(border): border-width mixin remove rogue call
34ddbed
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@AmitMY
fix(border): button outline
a1cf753
@AmitMY
Merge remote-tracking branch 'remotes/upstream/master' into border-rtl
f5063a6
@AmitMY
fix(border): button outline
8a79064
@AmitMY
fix(border): button outline
9d847e2
@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AmitMY @Ionitron @Manduro @hanzo2001 @brandyscarney @manucorporat