fix(input): use all supported attributes on both textareas and inputs #12028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Checking out the amazing keyboard/input refactor by @manucorporat, I came across some inconsistencies in the attributes that are supported for
ion-input
andion-textarea
.Changes proposed in this pull request:
autocomplete
andautocorrect
attributes for which theInput()
s already exist.maxlength
,spellcheck
andautocapitalize
onion-textarea
s as well.Ionic Version: 3.x (nightly)