Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): use all supported attributes on both textareas and inputs #12028

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

Manduro
Copy link
Contributor

@Manduro Manduro commented Jun 13, 2017

Short description of what this resolves:

Checking out the amazing keyboard/input refactor by @manucorporat, I came across some inconsistencies in the attributes that are supported for ion-input and ion-textarea.

Changes proposed in this pull request:

  • Add autocomplete and autocorrect attributes for which the Input()s already exist.
  • Add maxlength, spellcheck and autocapitalize on ion-textareas as well.

Ionic Version: 3.x (nightly)

@manucorporat
Copy link
Contributor

You right, thanks! will review it! in fact I think we should take a different approach in the future, since this does not scale really well hahah adding more and more attributes...

@manucorporat manucorporat merged commit 8041eed into ionic-team:master Jun 13, 2017
@Manduro Manduro deleted the input-attributes branch June 13, 2017 10:47
@ryanhalley
Copy link
Contributor

ryanhalley commented Aug 11, 2017

Hi. Regarding maxlength for ion-input and ion-textarea, was it your intention that the behaviour be: user types text and is not restricted during data entry, they leave the field, and field contents are then truncated to maxlength?
I was expecting the fields to prevent me typing in excess of maxlength during text entry, like HTML input does; could you please change the behaviour to this expected convention?

To be clear, I am testing with livereload (ionic cordova run android -cl), and release builds, and neither of them restrict during data entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants