fix(select): RTL fix for select #11352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTL fix for select
AmitMY
reviewed
Apr 25, 2017
| [dir="rtl"] .select-ios .select-icon .select-icon-inner { | ||
| right: 5px; | ||
| left: auto; | ||
| } |
There was a problem hiding this comment.
the lint rules for ionic indicate a need for a new line at the end of the file.
You can run it locally, gulp lint.sass, but you need to install ruby for that
Remove left right padding margin in favor of ionic-team#11342
|
@sijav This looks good. Please don't close this one though, it is good to know what is missing and where :) |
|
@AmitMY Yeah that was the purpose actually :D |
brandyscarney
requested changes
May 17, 2017
|
@brandyscarney No need - will be fixed in a global PR for border property, after the transform one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
RTL fix for select component
Changes proposed in this pull request:
Ionic Version: 2.x / 3.x
Fixes: #11351
Also there was
.item-wp.item-select ion-labelfor windows platform and.select-md .item-select ion-labelfor android which I couldn't reproduce it, if anyone have any idea what is these rules for please let me know.Thanks.