Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): RTL fix for input #11351

Closed
wants to merge 2 commits into from
Closed

Conversation

sijav
Copy link
Contributor

@sijav sijav commented Apr 25, 2017

Short description of what this resolves:

RTL fix for input

Changes proposed in this pull request:

  • fix padding and margin for RTL on input component

Ionic Version: 2.x / 3.x

Fixes: #11211

sijav added 2 commits April 25, 2017 12:12
no need to change this
@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@sijav Now that the big one is merged, can you please remove all references to padding, margin, left, and right? just keep the arrow flipped.

@sijav
Copy link
Contributor Author

sijav commented May 13, 2017

@AmitMY keep the arrow flipped? the only thing changed here was padding, margin, left, and right nothing else ...

@AmitMY
Copy link
Contributor

AmitMY commented May 13, 2017

@sijav oh oops, my bad.. I had all of your PRs open and I commented on the wrong one.
I meant here:
#11329

You can close this PR, as it is done here - #11342 - and merged.
Some fixes for 11342 that relate to this one, like overridden properties are suggested here - #11635

@sijav
Copy link
Contributor Author

sijav commented May 13, 2017

Closing this pr in favor of #11342

@sijav sijav closed this May 13, 2017
@sijav sijav deleted the rtl-fix-input branch May 15, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants