Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-label floating direction rtl , the label come almost in the middle not at the right. #11627

Closed
joesleiman opened this issue May 12, 2017 · 15 comments

Comments

@joesleiman
Copy link

joesleiman commented May 12, 2017

Ionic version:
3.0.1

*I'm submitting a bug report

Current behavior:
the label comes in the center. not right

Expected behavior:
the label should appear in the right side.
Steps to reproduce:

<ion-item>
     <ion-label floating style="direction:rtl;">joe</ion-label>
     <ion-input></ion-input>
</ion-item>

css: direction : rtl;

@jgw96 jgw96 added rtl labels May 12, 2017
@brandyscarney
Copy link
Member

Could you try updating to the latest version of Ionic: 3.2.0? There have been a lot of rtl improvements. I am not able to reproduce this on latest:

screen shot 2017-05-12 at 12 34 03 pm

cc @AmitMY

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@joesleiman The reason for this is that you use "direction: rtl"
you should instead, on the item itself (preferably on the entire html, but if that what you need so the item) add dir="rtl"

Here is the relevant fix: #11324

Sidenote: there is no plan to support direction: rtl as it doesn't really work on old browsers, or even current explorer/edge. (I mean, stuff like padding-block-start)

@joesleiman
Copy link
Author

@brandyscarbey Same issue on latest ionic version 3.2.0
@AmitMY : yes i discovered this . It's fine now

@joesleiman
Copy link
Author

I don't want to add dir="rtl" on html tag because the back button still same icon . I mean pointing to the left like this < . I need it to be >

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@joesleiman RTL support is WIP.
This one fixes the arrow for the input - #11351 - and will be merged when required changes are met.

@joesleiman
Copy link
Author

Hope they merge it soon.
You know something about the menu in rtl direction. It open from left to right . I think it is also solved but need to merge. Thankss

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@joesleiman since 3.1.0, if not specifying the menu side, and having dir="rtl" at the beginning of the doc it would open from the right.

The animation itself, and having it be changeable in run-time, is still open #11336

If your app is RTL only, and you want to make it always open from the right, for now, add [side]="'right'" and it will work.

@manucorporat
Copy link
Contributor

fixed in 3.2.1, but RTL support continues improving
cc @AmitMY

@joesleiman
Copy link
Author

@AmitMY no my app is ltr and rtl .
@manucorporat is there a 3.2.1 version . I know the last version is 3.2.0

@joesleiman
Copy link
Author

@AmitMY i put dir='rtl' at the begining and the menu still open from the left side but the menu button is moved to the right .

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@joesleiman yep, that open PR fixes it. I can't give an estimate to when it will be merged. @manucorporat might be able.

@joesleiman
Copy link
Author

Ok just another issue that i faced. Im using the google map from ionic native plugin. I noticed that if i change the background color of the page where the map is , the map disappear from the page.
And if i have an ion- select above the map , then i click on select a modal or pop up appear but i can't click on any option since they are above the map.
Also there a delay when i scroll the page . The map take time to start scroll.
Thanks in advance for everyone.

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

It seems like a different issue.. Please create an issue with ionic-native for the maps issue.

@joesleiman
Copy link
Author

Ok thank you...

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants