Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Replace 'person_reid_msg_ptr_' with 'person_reid_topic_' [issue #125] #126

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

Corsair-cxs
Copy link
Contributor

fix #125
What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev-2020.3 branch for ros_openvino_toolkit, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@LewisLiuPub
Copy link
Contributor

  • please don't add postfix "_ptr" to a pointer parameter.
  • please follow the naming convension for class parameters. e.g. xxx_msg_ptr --> xxx_topic.

@Corsair-cxs Corsair-cxs changed the title modified segmented_object_topic_ and commented segmented_object_topic_ [issue125] Replace person_reid_msg_ptr_ with person_reid_topic_ Mar 14, 2021
@Corsair-cxs Corsair-cxs changed the title Replace person_reid_msg_ptr_ with person_reid_topic_ Replace 'person_reid_msg_ptr_' with 'person_reid_topic_' Mar 14, 2021
@Corsair-cxs Corsair-cxs changed the title Replace 'person_reid_msg_ptr_' with 'person_reid_topic_' Replace 'person_reid_msg_ptr_' with 'person_reid_topic_' [issue #125] Mar 14, 2021
@LewisLiuPub LewisLiuPub merged commit b901ceb into intel:dev-ov2020.3 Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants