-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to Kubernetes v1.18.2 API #365
Conversation
perhaps we should take #364 in this PR too? |
can we document the steps to get 453ad1c easily done in |
/LGTM & agree with @mythi requests |
Sure, I'll update DEVEL.md FWIW Usually I follow this post https://www.openshift.com/blog/kubernetes-deep-dive-code-generation-customresources. Though it's assumed
Probably there's a better way. |
361b7aa
to
7bcefa9
Compare
I tried that, but it turned out v1beta1 and v1 have substantial differences. Here's an example for the two versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please squash commits
Oops, I didn't notice github automatically requested your reviews. Now it's ready for review. |
@mythi can you merge? |
the CI returns an error. perhaps retrigger the build to make sure it's OK? |
It seems I don't have permissions to restart jenkins pipelines. |
I usually just force push with a new commit id. |
Also fix the plugins and e2e tests
@mythi now it seems to be ready for merging. |
closes #317