Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpga: move to admissionregistration.k8s.io/v1 #364

Closed
mythi opened this issue Apr 15, 2020 · 0 comments · Fixed by #445
Closed

fpga: move to admissionregistration.k8s.io/v1 #364

mythi opened this issue Apr 15, 2020 · 0 comments · Fixed by #445
Assignees
@mythi
Labels
fpga FPGA device plugin related issue

Comments

@mythi
Copy link
Contributor

mythi commented Apr 15, 2020

Do you see other changes needed than:

diff --git a/deployments/fpga_admissionwebhook/base/fpga-mutator-webhook-cfg.yam                                           l b/deployments/fpga_admissionwebhook/base/fpga-mutator-webhook-cfg.yaml
index 79613bc..a2cb177 100644
--- a/deployments/fpga_admissionwebhook/base/fpga-mutator-webhook-cfg.yaml
+++ b/deployments/fpga_admissionwebhook/base/fpga-mutator-webhook-cfg.yaml
@@ -1,4 +1,4 @@
-apiVersion: admissionregistration.k8s.io/v1beta1
+apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
   name: fpga-mutator-webhook-cfg
diff --git a/deployments/fpga_admissionwebhook/mutating-webhook-configuration-tp                                           l.yaml b/deployments/fpga_admissionwebhook/mutating-webhook-configuration-tpl.ya                                           ml
index 339feed..73e3d27 100644
--- a/deployments/fpga_admissionwebhook/mutating-webhook-configuration-tpl.yaml
+++ b/deployments/fpga_admissionwebhook/mutating-webhook-configuration-tpl.yaml
@@ -1,4 +1,4 @@
-apiVersion: admissionregistration.k8s.io/v1beta1
+apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
   name: fpga-mutator-webhook-cfg
@mythi mythi mentioned this issue Apr 16, 2020
Merged
@msivosuo msivosuo assigned rojkov and unassigned bart0sh Jun 16, 2020
@msivosuo msivosuo assigned mythi and unassigned rojkov Sep 2, 2020
@mythi mythi mentioned this issue Sep 4, 2020
Merged
@msivosuo msivosuo added the fpga FPGA device plugin related issue label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythi mythi

Labels
fpga FPGA device plugin related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webhooks: move to admissionregistration.k8s.io/v1 mythi/intel-device-plugins-for-kubernetes
4 participants
@rojkov @mythi @msivosuo @bart0sh