-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review README files #356
Comments
We just did a bunch of updates. What is outdated?
Where's this? |
Particularly this It's not needed nowadays to clone the repo into a specific path. |
This section https://github.com/intel/intel-device-plugins-for-kubernetes#running-e2e-tests needs to be included in the README's ToC. |
true. I touched this part last time (f145541) and IIRC my thinking was that this gives a consistent starting point/path for each higher level section without any bigger re-work... |
Next steps:
|
Also make sure that those deployment files always pull an image that is compatible with the deployment. In PMEM-CSI, we ensure that for releases, but not for the development branch, and already had issue reports twice because users were using deployment files from an old revision of our master branch with the latest, incompatible "canary" images. |
Hi, based on the following PR, the plugin has already supported k8s 1.18. I think it is a critical problem. (Actually, we need several days to know that the plugin supports 1.18 or not.) Could you consider to update the top page README first? |
I just opened a PR to work on updates in the top page README. What is the concern? In principle, the release branches should be used for work that requires stability. |
Sorry that I asked without checking your project plan. Our team will test the master branch with k8s 1.18 and I believe we can wait for the official v0.18 release. |
Some files got outdated. For example
cmd/gpu_plugin/README.md
describes the installation procedure like we still usedep
instead ofgo mod
.The text was updated successfully, but these errors were encountered: