-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase ticker max length to 9 #45
Increase ticker max length to 9 #45
Conversation
Justification for this PR: This is in preparation for registering the SUNDAE token metadata; There's not a great abbreviation for SUNDAE, and we have already built up expectations around the token being named SUNDAE; changing it at the 11th hour would create significant confusion and create fertile soil for scammers. Additionally, it's already been listed with this ticker on ecosystem sites like CoinMarketCap. I've just noticed that the CIP here does specify a max length, but gives no justification for it; Is there a reason for 5 specifically? there are tokens on other chains with longer tickers, so it doesn't seem like an industry wide enforced limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully support this. I thought the limitation of 5 was annoying myself as my personal token I minted (and hasn't been added to registry yet because of this same issue) is DISASM.
Some evidence for distribution of token tickers in the wild on other chains: https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols |
Thanks! Can we also make corresponding update in README. Additional test in here would be handy too. 😅 I don't know if this is enough or is there a need to do a change also elsewhere in this repo, but maybe not... 🤔 I think we need the same change in cardano-wallet as there seems to be the same constraint there 🤷♂️ |
3086: increase metadata ticker length r=rvl a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Perhaps we should increase the max length to 9 so that the MILKSHAKE ticker is also possible? |
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
@piotr-iohk I'm going to address your comments today; Would you like me to bump the max length to 9, as suggested by rvl? |
I don't have strong opinion. I'm fine with 9. |
@piotr-iohk feedback addressed :) I wasn't 100% able to confirm the test locally, as I couldn't get it to run the newly built version of the code, it kept falling back to the version at 5 characters, but it seemed straightforward enough. |
@Quantumplation Would you also be able to raise a PR on CIP-26. There was no particular reason for choosing max length 5 - only that there should be some limit, and the ticker is meant to be a short identifier which abbreviates the token name. For example, the max ticker length on NASDAQ is 5, and MSFT is the ticker for Microsoft. If token creators choose long tickers, they may get truncated in GUIs. |
Will do :) |
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to ~6~ 9 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Took me a little while @rvl, but here you go: cardano-foundation/CIPs#207 |
In the wild and on other chains, tickers get as long as 9 characters. Of relevance to me, SUNDAE is 6 characters, but CoinMarketCap recognizes a MILKSHAKE token with 9 characters. See https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols for real world data. Also relevant: input-output-hk/offchain-metadata-tools#45
No description provided.