Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ticker max length to 9 #45

Conversation

kodemill
Copy link
Contributor

No description provided.

@Quantumplation
Copy link
Contributor

Quantumplation commented Jan 18, 2022

Justification for this PR: This is in preparation for registering the SUNDAE token metadata;

There's not a great abbreviation for SUNDAE, and we have already built up expectations around the token being named SUNDAE; changing it at the 11th hour would create significant confusion and create fertile soil for scammers.

Additionally, it's already been listed with this ticker on ecosystem sites like CoinMarketCap.

I've just noticed that the CIP here does specify a max length, but gives no justification for it; Is there a reason for 5 specifically? there are tokens on other chains with longer tickers, so it doesn't seem like an industry wide enforced limit.

Copy link
Contributor

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully support this. I thought the limitation of 5 was annoying myself as my personal token I minted (and hasn't been added to registry yet because of this same issue) is DISASM.

@Quantumplation
Copy link
Contributor

Some evidence for distribution of token tickers in the wild on other chains:

https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols

@piotr-iohk
Copy link
Contributor

Thanks! Can we also make corresponding update in README.

Additional test in here would be handy too. 😅

I don't know if this is enough or is there a need to do a change also elsewhere in this repo, but maybe not... 🤔
@rvl @sevanspowell.

I think we need the same change in cardano-wallet as there seems to be the same constraint there 🤷‍♂️

piotr-iohk pushed a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 18, 2022
iohk-bors bot added a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 19, 2022
3086: increase metadata ticker length r=rvl a=piotr-iohk



- [x] Iincrease metadata ticker length to 6 digits

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number
input-output-hk/offchain-metadata-tools#45


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@rvl
Copy link
Contributor

rvl commented Jan 19, 2022

Perhaps we should increase the max length to 9 so that the MILKSHAKE ticker is also possible?

iohk-bors bot added a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 19, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk


- [x] Iincrease metadata ticker length to 6 digits

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-1362

input-output-hk/offchain-metadata-tools#45


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@Quantumplation
Copy link
Contributor

Quantumplation commented Jan 19, 2022

@piotr-iohk I'm going to address your comments today; Would you like me to bump the max length to 9, as suggested by rvl?

@piotr-iohk
Copy link
Contributor

Would you like me to bump the max length to 9, as suggested by rvl?

I don't have strong opinion. I'm fine with 9.

@Quantumplation
Copy link
Contributor

@piotr-iohk feedback addressed :) I wasn't 100% able to confirm the test locally, as I couldn't get it to run the newly built version of the code, it kept falling back to the version at 5 characters, but it seemed straightforward enough.

@kodemill kodemill changed the title Increase ticker max length to 6 Increase ticker max length to 9 Jan 19, 2022
@rvl
Copy link
Contributor

rvl commented Jan 19, 2022

@Quantumplation Would you also be able to raise a PR on CIP-26. There was no particular reason for choosing max length 5 - only that there should be some limit, and the ticker is meant to be a short identifier which abbreviates the token name. For example, the max ticker length on NASDAQ is 5, and MSFT is the ticker for Microsoft. If token creators choose long tickers, they may get truncated in GUIs.

@sevanspowell sevanspowell merged commit d8786f4 into input-output-hk:master Jan 20, 2022
@Quantumplation
Copy link
Contributor

Will do :)

iohk-bors bot added a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 20, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk


- [x] Iincrease metadata ticker length to 6 digits

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-1362

input-output-hk/offchain-metadata-tools#45


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 20, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk

- [x] Iincrease metadata ticker length to ~6~ 9 digits

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-1362

input-output-hk/offchain-metadata-tools#45


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
rvl pushed a commit to cardano-foundation/cardano-wallet that referenced this pull request Jan 21, 2022
@Quantumplation
Copy link
Contributor

Took me a little while @rvl, but here you go: cardano-foundation/CIPs#207

KtorZ pushed a commit to cardano-foundation/CIPs that referenced this pull request Feb 15, 2022
In the wild and on other chains, tickers get as long as 9 characters.

Of relevance to me, SUNDAE is 6 characters, but CoinMarketCap recognizes
a MILKSHAKE token with 9 characters.

See https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols
for real world data.

Also relevant: input-output-hk/offchain-metadata-tools#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants