increase metadata ticker length #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
approved these changes
Jan 19, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 19, 2022
3086: increase metadata ticker length r=rvl a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: Probably: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 19, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: Probably |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 20, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to 6 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 20, 2022
3086: increase metadata ticker length r=piotr-iohk a=piotr-iohk - [x] Iincrease metadata ticker length to ~6~ 9 digits ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-1362 input-output-hk/offchain-metadata-tools#45 Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Timed out. |
|
bors r+ |
rvl
force-pushed
the
piotr/increase-ticker-length
branch
from
fd4000c to
63fec9e
Compare
|
Canceled. |
|
I just rebased and pushed. We need to update the token metadata unit tests because some ticker examples which were previously invalid are now valid. |
rvl
force-pushed
the
piotr/increase-ticker-length
branch
from
63fec9e to
68e5f87
Compare
|
Looking at the bors jobs above, the integration tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
69 digitsComments
Issue Number
ADP-1362
input-output-hk/offchain-metadata-tools#45