Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema/readme with new ticker max length #207

Merged

Conversation

Quantumplation
Copy link
Contributor

In the wild and on other chains, tickers get as long as 9 characters.

Of relevance to me, SUNDAE is 6 characters, but CoinMarketCap recognizes
a MILKSHAKE token with 9 characters.

See https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols
for real world data.

Also relevant: input-output-hk/offchain-metadata-tools#45

In the wild and on other chains, tickers get as long as 9 characters.

Of relevance to me, SUNDAE is 6 characters, but CoinMarketCap recognizes
a MILKSHAKE token with 9 characters.

See https://ethereum.stackexchange.com/questions/25619/is-there-length-limits-on-token-symbols
for real world data.

Also relevant: input-output-hk/offchain-metadata-tools#45
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's already been consensus as of input-output-hk/offchain-metadata-tools#45 (comment) I think this is fait accompli.

@Quantumplation
Copy link
Contributor Author

@rphair Sorry about that; I figured those in a position to object would be the ones reviewing that PR. If you have major objections happy to revisit them now.

The main argument here was that CMC recognizes tickers up to 9 characters, so the cat might be out of the bag on that.

Originally I was going to bump it up to 6 (to cover SUNDAE, since that's what people are using in the wild), but after doing some digging on what other systems support, came to the 9 character PR.

@rphair
Copy link
Collaborator

rphair commented Feb 1, 2022

@rphair Sorry about that;

no worries @Quantumplation ... I didn't follow the discussion but read it retroactively & I agree with the proposition and the apparent consensus about the 9-character limit. As a CIP editor I'm only interested in the consistency between that discussion & this proposed change to the CIP, which I believe we have. 😎

Personally I think it's also a good idea... though the industry as a whole has some 11-character token names, I feel these are no longer "tickers" because they become descriptive rather than abbreviations. But that is just my opinion & doesn't factor into my approval of this CIP change as originally posted. 🤓

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KtorZ KtorZ merged commit fe63776 into cardano-foundation:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants