Fix arm cross compilation with ghc 8.6.5 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TravisWhitaker can you please check that native aarch64 still works ok with this change? |
hamishmack
force-pushed
the
hkm/arm-ghc865-fix
branch
from
5fcbbcd to
0d35e65
Compare
|
@angerman @hamishmack This makes haskell.nix unusable (at least with GHC 8.8.x) on aarch64. There is infinite recursion somewhere: Is there haskell.nix CI for aarch64? |
|
Hmm, I might've spoken too soon. I'm bisecting now.... |
hamishmack
added a commit
that referenced
this pull request
Jun 7, 2020
This should fix the infinite recursion issue with #654
angerman
pushed a commit
that referenced
this pull request
Jun 7, 2020
* ghc 8.10 * Adds/Updates/Removes materialization files * Disable one-shot-kqueue-on-macos patch on ghc-8.10 * Test ghc883 and ghc8101 but only with nix 20.03 * Various smaller fixes. This should fix the infinite recursion issue with #654 Co-authored-by: Lennart Spitzner <[email protected]>
|
@hamishmack 15fc6b3 indeed fixed this on native aarch64, thanks! |
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
* ghc 8.10 * Adds/Updates/Removes materialization files * Disable one-shot-kqueue-on-macos patch on ghc-8.10 * Test ghc883 and ghc8101 but only with nix 20.03 * Various smaller fixes. This should fix the infinite recursion issue with input-output-hk#654 Co-authored-by: Lennart Spitzner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#620 broke cross compilation to Aarch64 with ghc 8.6.5.
This can be observed by running:
This change reinstates Aarch64 support.