Native aarch64 support #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisWhitaker
force-pushed
the
aarch64-native
branch
3 times, most recently
from
d3ac22a to
2f04bf4
Compare
TravisWhitaker
force-pushed
the
aarch64-native
branch
5 times, most recently
from
c23f9c3 to
bd3a91b
Compare
|
Working on rebasing this... |
TravisWhitaker
force-pushed
the
aarch64-native
branch
from
bd3a91b to
258c62d
Compare
angerman
reviewed
May 23, 2020
|
This looks pretty good, I just wish we had some earlier bootstrap compiler. I'd love to try our 8.6.5 natively on aarch64 with haskell.nix |
TravisWhitaker
force-pushed
the
aarch64-native
branch
5 times, most recently
from
dd0e3f6 to
6079f9d
Compare
angerman
reviewed
May 29, 2020
angerman
reviewed
May 29, 2020
overlays/haskell.nix
Outdated
| @@ -172,7 +172,7 @@ final: prev: { | |||
| # Package sets for all stackage snapshots. | |||
| snapshots = import ../snapshots.nix { inherit (final) lib ghc-boot-packages; inherit mkPkgSet stackage excludeBootPackages; }; | |||
| # Pick a recent LTS snapshot to be our "default" package set. | |||
| haskellPackages = snapshots."lts-14.13"; | |||
| haskellPackages = snapshots."lts-15.13"; | |||
There was a problem hiding this comment.
I understand the motivation for this, though this should be a separate PR, as it bumps the default compiler in haskell.nix from 8.6 to 8.8.
There was a problem hiding this comment.
Would you rather have the LTS major version depend on the target architecture in this PR?
There was a problem hiding this comment.
^^^ Went ahead and added this for now.
angerman
reviewed
May 29, 2020
TravisWhitaker
force-pushed
the
aarch64-native
branch
4 times, most recently
from
0e6847b to
ffcbaf6
Compare
TravisWhitaker
force-pushed
the
aarch64-native
branch
from
ffcbaf6 to
dec8115
Compare
reduce external dependencies
|
bors try |
tryBuild failed |
|
bors try |
tryBuild failed |
|
bors try |
tryBuild succeeded |
|
@angerman thanks so much for all your help with aarch64 support! |
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
* native aarch64 support Co-authored-by: Moritz Angermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow haskell.nix to be used for native builds on aarch64. There are a few changes necessary for this: