Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghc 8.10.1 #541

Merged
merged 73 commits into from
Jun 7, 2020
Merged

Add ghc 8.10.1 #541

merged 73 commits into from
Jun 7, 2020

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@hamishmack hamishmack changed the title Add ghc 8.10 Add ghc 8.10.1 Apr 10, 2020
@michaelpj
Copy link
Collaborator

Are we building our tests etc across multiple GHC versions? I'm actually not sure what version gets used for the tests...

@hamishmack
Copy link
Collaborator Author

I think the tests only run for 8.6.5. It would be nice to add 8.8.3 and 8.10.1. I should have made this a draft PR. Pushed it to see if it built and eval is failing on hydra right now because of an issue building the windows cross compiler.

@hamishmack hamishmack changed the title Add ghc 8.10.1 WIP: Add ghc 8.10.1 Apr 10, 2020
@lspitzner
Copy link
Contributor

hey, I tried this, and ran into

"attribute '0.6.1' missing," -- in plan/default.nix: "ghc-prim".revision = (((hackage."ghc-prim")."0.6.1").revisions).default;

As advised by @angerman I tried rebasing it on top of current master at https://github.com/lspitzner/haskell.nix/tree/hkm/ghc8101-rebased. Fixing the merge conflicts was trivial, but the result did not work, however I was able to get a working build by

a) Inserting commit 6642ebc to disable a non-working patch that got added recently (could maybe look into making it 8.10 compatible)
b) Reverting 983cdae (I did not add a commit, but simply checked out the commit before that)

So on top of 6642ebc I get a build that seems to compile my simple test package across 8.4,8.6,8.8,8.10. But I have tested only the basic ghc non-crosscompile route, no ghcjs either.

For some reason I had to recompile all ghcs (not just 8.10). Maybe because the patch set got modified? I still was confused that there is a difference between current master and my branch. Not sure if there is a way to avoid that.

@maksbotan
Copy link
Contributor

FYI: for me the issue with 0.6.1.0 missing (that is actually a hpc version) was fixed by adding hpc to bootPkgs at modules/component-driver.nix.

This is #524 all over again, because hpc bundled with 8.10 did not get uploaded to Hackage.

@hamishmack hamishmack changed the title WIP: Add ghc 8.10.1 Add ghc 8.10.1 Jun 6, 2020
@hamishmack hamishmack requested a review from angerman June 6, 2020 16:49
This should fix the infinite recursion issue with #654
@angerman
Copy link
Collaborator

angerman commented Jun 7, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Jun 7, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 7, 2020

@angerman angerman merged commit 15fc6b3 into master Jun 7, 2020
@iohk-bors iohk-bors bot deleted the hkm/ghc8101 branch June 7, 2020 03:05
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
* ghc 8.10
* Adds/Updates/Removes materialization files
* Disable one-shot-kqueue-on-macos patch on ghc-8.10
* Test ghc883 and ghc8101 but only with nix 20.03
* Various smaller fixes.

This should fix the infinite recursion issue with input-output-hk#654

Co-authored-by: Lennart Spitzner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants