-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ghc 8.10.1 #541
Add ghc 8.10.1 #541
Conversation
Are we building our tests etc across multiple GHC versions? I'm actually not sure what version gets used for the tests... |
I think the tests only run for 8.6.5. It would be nice to add 8.8.3 and 8.10.1. I should have made this a draft PR. Pushed it to see if it built and eval is failing on hydra right now because of an issue building the windows cross compiler. |
hey, I tried this, and ran into
As advised by @angerman I tried rebasing it on top of current master at https://github.com/lspitzner/haskell.nix/tree/hkm/ghc8101-rebased. Fixing the merge conflicts was trivial, but the result did not work, however I was able to get a working build by a) Inserting commit 6642ebc to disable a non-working patch that got added recently (could maybe look into making it 8.10 compatible) So on top of 6642ebc I get a build that seems to compile my simple test package across 8.4,8.6,8.8,8.10. But I have tested only the basic ghc non-crosscompile route, no ghcjs either. For some reason I had to recompile all ghcs (not just 8.10). Maybe because the patch set got modified? I still was confused that there is a difference between current master and my branch. Not sure if there is a way to avoid that. |
# Conflicts: # overlays/bootstrap.nix # overlays/ghc-packages.nix # overlays/haskell.nix
FYI: for me the issue with This is #524 all over again, because |
This should fix the infinite recursion issue with #654
bors try |
tryBuild succeeded |
* ghc 8.10 * Adds/Updates/Removes materialization files * Disable one-shot-kqueue-on-macos patch on ghc-8.10 * Test ghc883 and ghc8101 but only with nix 20.03 * Various smaller fixes. This should fix the infinite recursion issue with input-output-hk#654 Co-authored-by: Lennart Spitzner <[email protected]>
No description provided.